Re: Re[4]: [TSVN] Official request... Directory Diff

Jean-Marc van Leerdam wrote:
MB>> The #define'd diff colors each have a particular meaning.

MB>> Each one of the m_BinDiffColors means exactly the same - that a
MB>> (precisely) similar block of text was found in both lines that are
MB>> being compared. In the m_BinDiffColors case, each substring matched
MB>> gets a different color from this array.

MB>> The reason for each match to get a different color is that the exact
MB>> position of the matched strings does not matter; they can be shuffled
MB>> inside the two lines. The color is used to indicate which strings
MB>> relate from one line to the other.

> Ok, in that case using similar colors will even add to the confusion,
> especially if the matched blocks are not on/near the same position in
> both lines.

Why would you find it confusing that similar meaning is coded in similar colors?

Have you even tried using the line-diff feature? :-)

> The colors of matched blocks should also stay away from the other
> colors in use (added, deleted, conflict). However, since these colors
> can be changed by the end-user this creates a challenge :)
> Ideally the end user should be allowed to select the 10 different
> block colors to use in the line-diff window (so they can be made
> suitable for his/her choice).

I disagree, this clutters the configuration interface, and is not
something that most users would want to change.

(A registry setting would be fine though, if it had a default so that
it works without too).

> If creating a GUI for this is not (yet) an option, I would suggest
> using light colors, at most two shades per primary color (to avoid
> mixing them up on monochrome/low color monitors ;)

TSVN runs on Win2000 and above.
The installed Windows 2000 user base using monochrome monitors is, I
think, very small =).

> Is it possible to change not only the backgroubd color, but foreground
> as well? In that case, perhaps matched text can be displayed in blue
> on one of the block-color backgrounds, and added/removed/conflicted in
> black on the added/removed/conflicted background?

No idea if that's possible.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Tue Mar 15 15:22:17 2005