Re: [TSVN] Re: Tortoise/Cache hanging Explorer?

Will Dean wrote:

>> Will: the docs for ::InterlockedExchange tell that the variable has to
>> be on a 32-bit boundary or it will fail on SMP machines. Since /Zp
>> isn't set and there's no pack pragma, do you know what's the default?
>> If the default is 1, then a simple pragma could solve the problem...
>
>
> The default is something like 8 or 16. I'd be very surprised if that
> was the problem. I think it's something to do with the way the
> named-pipe is handled now, but I don't have time to look into the details.

So you're not sure about the default either.

> Just put the named-pipe loop back how it was, and I bet everything will
> be OK. The tidy termination stuff is an irrelevance.

Why? We need a message loop. For several reasons:
- clean shutdown of the application
- debugging window/dialog in the future.

So why remove something instead of fixing it?

> As an aside, and it's not related to this problem, the message loop
> should also look at the return value of GetMessage and act accordingly.

I'll check that.

>> I'll add the pragma anyway - it won't hurt if it's there.
>
> I disagree, but I think I'll relinquish any ownership of the cache code
> now, and leave it to you. I don't have time to work on it at the
> moment, and I don't want to sit on the sidelines sniping about quality.

I don't understand your arguments here. Since neither me nor you don't
know what the default of /Zp is, a pragma will make this absolutely
clear, no matter what the default is. And it will stay clear even if the
default changes.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org