Re: [TSVN] Small bug in commit dialog

On Thu, 10 Feb 2005 09:17:24 +0000, Will Dean <svn@indcomp.co.uk> wrote:

> >I'd vote for one simple option "Don't close on errors". If the dialog
> >closes on conflicts/merges/etc. and the users thinks "I'd wanted to
> >see that!" then I'd recommend to _not_ close the dialog automatically.
>
> It's funny - I think we all agree on the principle, what we're going to
> argue over is what constitutes an 'error'.

An error is a condition which makes a desired function to not finish -
or something like that ;)

> Personally, I consider a conflict to be an "error" - it almost certainly
> prevents a project compiling, it needs further (T)SVN activity to fix it,

It needs user activity. TSVN can't resolve a conflict automatically.

> and that activity is most easily carried out from the progress dialog.

You can do the same from the "Check for modifications" dialog.

> However, I recognise that a conflict isn't "an error" in a technical sense...
>
> I would vote for treating conflicts as errors, for the purposes of deciding
> whether or not to close. I think others disagree with this.

The problem I see here is:
If we make the dialog not close on conflicts, then we will end up with
more requests like the one from Lübbe. Then users want a separate
option to not close the dialog not just for conflicts, but for merges,
adds (I'd like to see what new files were added!), deletes (why the
hell was my file removed and who did that?), moves (hey, I want my
file here, not there!), ... which would never end.
I was afraid the first time I added the "Don't close on conflicts"
option that something like this would happen. I admit it took some
time until this came up, but it did.

Stefan

-- 
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org