[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: [TSVN] Small bug in commit dialog

From: Lübbe Onken <l.onken_at_rac.de>
Date: 2005-02-10 08:33:23 CET

Will wrote:

> Because I wrote:
> >A while ago I suggested to replace the two checkboxes on the
> main settings
> >page with a combobox 'progress dialog' that contains four options:
> >- Always open
> >- Don't close on merges (green lines)
> >- Don't close on conflicts (red lines)
> >- Don't close on errors
> >
> >I think it's time to raise this issue again :-)
>
> Can I make two variant suggestions:
>
> 1. As above, but radio buttons rather than a combo.
Radio buttons need more space than a combobox like 4 lines versus 1 line

> OR
> 2. Get rid of the 'close on errors' options, and always have
> it stay open
> when there's an error or conflict. (So then there would just be one
> auto-close option, which would only apply if there were no errors.)
>
> Would option '2' be bad in some way I haven't thought of?
How would you define 'no errors'? Maybe there's some information I'd like to
have, which is not an error. Conflicts are no errors, neither are successful
merges.

Basically we 'need' only two options. 1) 'close never' and 2) 'don't close
when user action is required'.

I split up 2) in three points to come up with four in total, sorted in order
of message importance.
2a) don't close on merges (because then I can check in the progress dialog
which files have been modified by someone else and may require a review)
2b) don't close on conflicts (what we have right now)
2c) don't close on errors (I believe we should never close the progress
dialog if an error has occured)

Cheers
- Lübbe

--
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Thu Feb 10 08:34:14 2005

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.