[TSVN] Re: Small bug in commit dialog

Will Dean wrote:
> At 17:35 09/02/2005 +0100, you wrote:
>
>> A while ago I suggested to replace the two checkboxes on the main
>> settings page with a combobox 'progress dialog' that contains four
>> options:
>> - Always open
>> - Don't close on merges (green lines)
>> - Don't close on conflicts (red lines)
>> - Don't close on errors
>>
>> I think it's time to raise this issue again :-)
>
> Can I make two variant suggestions:
[snip]
> 2. Get rid of the 'close on errors' options, and always have it stay
> open when there's an error or conflict. (So then there would just be
> one auto-close option, which would only apply if there were no
> errors.)
>
> Would option '2' be bad in some way I haven't thought of?

IMHO we should _never_ auto close if there is an error or a serious
warning (eg. conflicts). Merging is normally benign, so someone might
want to keep that as a warning. But then the easy option is just to turn
off auto-close altogether, which is what I do as I always like to review
what has happened.

My vote goes to reducing complexity, so there is just 1 checkbox:

[ ] Auto-close if no errors or warnings

although you might want to word that differently.

Simon

-- 
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org