Re: [TSVN] Changes in 2634

At 13:09 08/02/2005 +0100, you wrote:

>Maybe that was your intention. But you didn't clear the m_status.entry
>pointer (set to NULL), so in GetAnswerToRequest(), the
>sizeof(TSVNCacheResponse) was used for the length to send the data
>back.

Aha, that's where my 'confusing' comes in. It's already established by
CStatusCacheEntry::SetStatus that m_svnStatus.entry is NULL, and
m_svnStatus is what's used to set response.m_status.

>That could (and IMHO should) be changed.

We don't need a message loop to correctly shut-down a console app.

I'll deal with it.

>The apr pools aren't freed.

Well, the OS will recover the memory, but I agree that if there were any
finalizers (or whatever APR calls them), then they wouldn't get run, which
would be bad.

> > > Also, apr doesn't
> > >really like it if it's not closed properly.
> >
> > I'm not sure it would know. (A dead person doesn't have much of an opinion
> > on his own death...)
>
>No, but it will have a mess lying around, including the dead body.

The OS cleans up process resources when a process terminates.

But I'm not arguing against tidy shutdown, only that I suspect that untidy
shutdown doesn't have any side-effects in this instance.

Cheers,

Will

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Tue Feb 8 13:22:06 2005