[TSVN] Changes in 2634

Stefan,

I'm not overjoyed about some of the changes in 2634, particularly the
wrapping of code in SVNFolderStatus in a catch(...) block.

The response from the cache (after the pointer fix-up which occurs in
RemoteCacheLink) should be consistent, and shouldn't have broken data in it.

If we feel we need to be defensive about data coming in from the cache (I
don't think we do, actually), then I think we should validate it in
RemoteCacheLink, and not just munge around it with catch(...) blocks in the
code which uses the data.

Have you been getting shell crash reports related to the new cache which
were tracked-down to bad data being delivered to this bit of code?

I haven't changed anything in SVNFolderStatus, but I would like to register
a -10 vote on this. (Do I need 9 sock-puppets to register a -10?)

Anyway, I'm shortly going to commit some significant changes to the cache,
so it's probably best not to change anything else in there for the moment...

Cheers,

Will

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Tue Feb 8 11:13:40 2005