Re: [TSVN] Re: Possible bug in external diff option

Will Dean wrote:
> At 09:59 28/01/2005 +0000, you wrote:
>
>> I was just about to suggest that too. I am guessing that pre 1.1.3 you
>> could get away with just supplying the program name with no parameters,
>> and TSVN would just supply the filenames anyway. So if there are no user
>> params on the command line, add %base and %mine. Saves creating yet
>> another error message.
>
>
> But why did this change?

The reason for this change was that if we just add the paths to the two
files to diff to the command line, some diff programs don't work
anymore. Some diff programs use additional params and expect them in a
certain order. e.g.
diffprogram.exe specialparam1 file1 file2 specialparam2

if we now simply check if %base and/or %mine and add file1 file2 if
they're not there, then those diff programs break.

Sure, we could not only check for %base and/or %mine but also if there
are any other params added already and then _not_ add the filepaths...

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org