Re: [TSVN] Question about 2560

On Thu, 27 Jan 2005 22:17:27 +0000, Will Dean <svn@indcomp.co.uk> wrote:
>
> Stefan,
>
> Just for my own interest, I'm trying to understand rev 2560, and the stuff
> with the sub-pools.
>
> Can you try and explain what was going wrong here?

Deleting two files with 1.1.3 will crash. From the crashreports, I
could see that the crash happens inside the Subversion lib. But why
only on the second file and not the first one too? So I started
digging: we're reusing the global pool for the deletes, and that's
something the delete function doesn't like at all. So I had to use a
local pool for it. But that didn't work either, because the
MakePathArray() and logMessage() still used the global pool (I was
basically *mixing* pool then). So I changed those two functions to
accept a pool param so I can allocate all required mem in _one_ local
pool.
Now the delete function works again.

Stefan

-- 
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org