Will Dean wrote:
> That sounds pretty good. I'd make two suggestions/modifications:
>
> 1. Instead of producing TortoiseOverlay.dll initially, we just make some
> very minor modifications to it to allow a *run time* selection of
> whether it fetches from SVN directly, or uses the TSVNCache system.
> This could be a registry flag, cached with your normal registry-caching
> system. It would be a minor change to SVNFolderStatus and to the
> Overlay handler.
>
> This would allow people to switch between the new and old cache very
> easily, if there were problems. I don't think this would be a
> high-risk modification to the shell extension. If we were ever happy
> with the external cache, we could then remove the SVN code from the
> shell-extension.
I agree. That's little work to make use of the new caching so people can
try it out without a big risk.
> 2. If we are going to split the shell extension up into PropPage and
> others, could we take the opportunity to slightly upgrade their
> implementation? I would suggest that we went to ATL, at least for the
> PPage, and made the DLL self-registerying. This would simplify the WiX
> install script (fewer GUIDs in there), and would make development a
> little easier (it would be easy to switch between multiple locations for
> the DLLs, for example)
> I also am slightly unconvinced of the correctness of some aspects of the
> current COM object implementation (ref-counting is not MP-Safe for
> example).
I guess we can do that. I'll have a look once we got the new cache up
and running and we're ready to make the split.
> I would like to hold-off merging to the trunk just for a bit longer, as
> I am not happy with the way that directory status is handled at the
> moment, and am in the middle of a re-write.
Ok, but I suggest not waiting too long with it. Otherwise your branch
will drift to far apart from trunk and you might get into serious
troubles resolving conflicts.
Stefan
--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest Interface to (Sub)Version Control
/_/ \_\ http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Sun Jan 23 17:41:23 2005