[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [TSVN] diff added file with history from log message dialog

From: SteveKing <steveking_at_gmx.ch>
Date: 2005-01-23 10:11:42 CET

George Wieggers wrote:
> Second attempt. Take a look at this patch.
>
> Note: the function GetTempFilePath has a strange behaviour. It assumes
> you'll use the return value to create the temp file immediately,
> before calling GetTempFilePath again.
> Otherwise, it returns the same result twice. I worked around it in
> CLogDlg::StartDiff in this patch.
>
> + // fetch the second tmp filename AFTER the first file really exists.
> + // otherwise we'll end up with two identical paths
> + // BUGBUG, does GetTempFilePath really have to behave that way?

Thanks for that. I changed the GetTempFile() method so it doesn't return
the same temp file path twice, therefor I slightly modified your patch.
Committed in revision 2516.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Sun Jan 23 10:12:15 2005

This is an archived mail posted to the TortoiseSVN Dev mailing list.