Re: [TSVN] "diff" command in context menu when selecting an added file

At 14:05 06/01/2005 +0100, you wrote:

>if we allow diffs of added files then we also have to enable them in
>all the other places too (CSVNStatusListCtrl, ...).

Maybe when I've finished unifying the path-passing APIs, I might think
about unifying all the context menus in the system - both in the dialogue
boxes and in the shell.

Although the method of building the menus is different, many of the
decisions about what to put on a context menu must be the same, as are the
actions when you choose them. One could imaging factoring all the command
code out of the TortoiseProc::InitInstance in such a way as to allow those
commands to be used either by the command line interface, or by the
internal context menu handlers.

For example, if the shell context menu wanted to do an Add, it could build
a path list and then call a function which said "Send this path list to
TortoiseProc and tell it add them". If a TProc right-click handler wanted
to do an add, it would build the path list and send it to a function with
an identical signature, but which didn't need to invoke an instance of
TortoiseProc to do it.

And of course, everybody would use an SVNFolderStatus cache to get any
status info they needed...

I suspect that there would be some tricky edge-cases, and it's quite a lot
of work, but it's something to think about.

I have this feeling that one day the whole of TSVN is going to reduced to
about 6 carefully chosen lines of code.

>I'll check what I can do here. Just don't expect it to be done today -
>have some errands to run...

It's not a big problem at the moment, for sure. The guy who wanted the
functionality has added it himself anyway!

Cheers,

Will

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Thu Jan 6 14:49:54 2005