[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [TSVN] "diff" command in context menu when selecting an added file

From: Will Dean <svn_at_indcomp.co.uk>
Date: 2005-01-06 13:45:09 CET

At 13:26 06/01/2005 +0100, you wrote:

>That's what I mean: I don't want to disable the menu if it's a clean
>add - TMerge can handle non-existing files and just shows an empty
>file on the left and the added file on the right. Maybe other visual
>diff tool can do that too - or they will be able to do so one day.

I'm lost now! Isn't that exactly what the OP's patch did? Anyway, I'll
leave it to you.

>If you remember: it was you who created the function GetCachedItem()
>for speed reasons: that way we can prevent a call to PathIsFolder if
>the item already is in the cache. Only if it's not in the cache, then
>we have to call that.

Oops! I don't think that's a great improvement now. I didn't understand
the code very well then.

With hindsight, it would have been better just to move the

         BOOL bHasAdminDir = g_ShellCache.HasSVNAdminDir(filepath, bIsFolder);

         //no overlay for unversioned folders
         if ((!bColumnProvider)&&(!bHasAdminDir))
                 return &invalidstatus;

bit below the cache lookup in GetFullStatus.

I don't think having the cache-lookup in its own function is a bad idea,
especially as it's got more complicated.

Cheers,

Will

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Thu Jan 6 13:46:20 2005

This is an archived mail posted to the TortoiseSVN Dev mailing list.