[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [TSVN] "diff" command in context menu when selecting an added file

From: Will Dean <svn_at_indcomp.co.uk>
Date: 2005-01-06 10:45:58 CET

At 10:31 06/01/2005 +0100, you wrote:

>I haven't tested that, but what does GetPristinePath() return for a
>moved file? and for a copied file?

I think that a better way to deal with this might be to use the 'copied'
flag in svn_wc_status_t, which seems to specifically cover this situation,
and must be available 'for free'.

Unfortunately, GetAllStatus doesn't keep/return this info at the moment,
and although lots of ugly hacks can be thought of to get around this, I
don't have anything very elegant to mind at the moment.

>I think that would be the easiest way to deal with it. But it would
>definitely need a FAQ entry because people _will_ complain about their
>diff tool not working.

Well, we could deal with that in the code which starts the external diff
viewer, and not launch for non-existant files, or something like that.

But it would be better to deal with it in the shell-extension, really.

I suppose a simple hack which wouldn't be *too* awful would be to have a
flag in SVNStatus called something like m_bLastStatusQueryFoundCopiedFiles,
and set this in the getallstatus callback if the copied flag is seen. Then
the shell-extension can apply this appropriately. It would be meaningless
when there are multiple files processed by GetAllStatus, but the shell
extension is already specifically excluding that in this particular situation.

Will

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Thu Jan 6 10:46:27 2005

This is an archived mail posted to the TortoiseSVN Dev mailing list.