Re: [TSVN] "diff" command in context menu when selecting an added file

On Wed, 05 Jan 2005 22:26:28 +0100, George Wieggers
<g.wieggers@zonnet.nl> wrote:

> IMHO TortoiseSVN should be able to do a "diff" on added files. Let me
> try to explain why.
>
> svn allows you to do the following
>
> - svn add foo.txt
> - svn diff foo.txt
>
> (will show the entire file in the diff)

As a unified diff, yes.

> - svn commit
> - svn cp foo.txt bar.txt
>
> (now edit bar.txt)
>
> - svn diff bar.txt
>
> (svn diff will show your modifications)

Again, as a unified diff.

> This isn't possible in TortoiseSVN yet, because the "diff" command is
> supressed for every "added" file.

It's suppressed for a reason: a 'diff' on a working copy file always
means comparing the working copy file with its base. And since added
files don't have a base yet, this won't work at all.

> The patch at the bottom of this message enables the diff command for
> added files.
> I've built and tested this patch and it works as expected.

You've tested that? I don't think so.
You're patch only activates the context menu 'diff' for added files
too. But I'm sure you haven't tested the actual diff command. It won't
work! Because, as I mentioned above: added files don't have a base
yet, so there's nothing to compare them with.

Stefan

-- 
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org