[TSVN] More on CString vs std::string

My apologies to all those who can't get a word in edgeways about icons, and
I did say that I wouldn't discuss this any more, but....

Last night, I wrote some code for SVNStatus.cpp, which allows me to set-up
a filter list of paths and restricts the results returned from a GetStatus.
(This code is to help with a perf problem in certain circumstances, and
it's not what this post is about.)

Because this code is intended to be called from the U/I, I pass it an array
of CString, containing the paths.

Because SVNStatus.cpp is used by the shell extension which doesn't support
CString, this code is protected by #ifdef _MFC_VER

As an experiment, I just added #include <atlstr.h> to stdafx.h, and
included my filtering code into the shell extension.

Any guesses on how much bigger the DLL got with the addition of my
filtering setup and ATL CString?

0 bytes. Yup, that's right, it makes no difference at all.

I am *not* going to run-around changing perfectly working stdstrings into
CString for the sake of casually breaking code or doing an NIH-job on
Stefan's hard work, but I do think we can safely introduce CString into the
shell extension (if it brings benefits of code shared with TortoiseProc).

Bring on the dissent...

Will

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Wed Dec 22 15:03:33 2004