[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[TSVN] Perf regression in Status list

From: Will Dean <will.dean_at_indcomp.co.uk>
Date: 2004-12-21 20:20:49 CET

Hi,

The attached tiny patch fixes a problem I introduced in my refactoring of
SVNStatusListCtrl.

I was creating and destroying an SVNConfig object for each item in the
command-line response file. I hadn't realised quite how expensive the
construction of this object is.

Stefan, could you review this very minor change for suitability to go in
before Thursday? I think it's very low risk.

Interested in the 3000-item directory speed problems which have been
reported, I have been trying an 'Add' of about 3500 items, which are all
part of one selection, (rather than in a subdirectory) (i.e. the temp
response file has about 3500 items in it). This is a major stress test of
the status list control which, to be honest, it fails, in that it takes
minutes to load.

I do not currently have the expertise in the SVN API to know if there's a
better way we could do this than 3500 creations of the SVNStatus object and
calls to GetFirstFileStatus - but I think there probably is.

Not before Thursday, though...

Cheers,

Will

-- 
Will Dean - Industrial Computing Ltd
will.dean_at_indcomp.co.uk - http://www.indcomp.co.uk/
Elmcroft, Wyke Road, Gillingham, Dorset, SP8 4NG, UK
Tel: +44 1747 831001    Fax: +44 1747 824783

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org

Received on Tue Dec 21 20:38:35 2004

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.