[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[TSVN] Another commit dialog perf patch

From: Will Dean <svn_at_indcomp.co.uk>
Date: 2004-12-16 12:10:05 CET


Here's another set of patches which improve efficiency of the commit-log

Have saved a bit of PathIsDirectory calling by using the value from the

A few other changes mainly to try and avoid too much CString chatter.

I am still concerned about the 'check for files which differ only in case'
stuff in ListCtrl::Stat() - this loop just explodes given half a
chance. One of my test sets has about 32000 files in, and even though
nearly all of these are in unversioned folders, it still ran that loop in
Stat over 3 million times, though admittedly it didn't do much in it.

On a largeish WC I have, that loop runs about 1 million times, and did seem
to do rather more - stat() took about 10% of the run time. (70% was in the
SVN get status call).

Maybe it's now down in the noise and I shouldn't care anymore, but offends
me to see something running N-squared for a large 'N' when I think it could
probably be NLog(N) for a very small N. Something to think about for the
future, anyway.



To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org

Received on Thu Dec 16 12:11:00 2004

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.