Re: [TSVN] Commit dialog perf patch

At 10:33 16/12/2004 +0100, you wrote:

>Does *draft* mean you don't want this to be committed?

I mean I want *you* to take the blame when tomorrow's build is broken!

>UnicodeUtils: I'm not sure if using a CStringA really is faster than what
>we do now? But it looks good (and it works ;) ). So I'll leave it in.

That's not the point - that function used to make a 'new char[]' and then
copy it to a CStringA (which I assume requires the CStringA to alloc again
and copy the data. I have told the CStringA to alloc the data in the first
place.

>Yes, I guess since this bugfix the performance of the commit dialog
>depends mostly on fetching the status, i.e. on the Subversion library
>call. So not much to improve for us anymore.

It very much depends on the arrangment of the data, I think.

>Are you ok if I commit your patch? (beware of conflicts when you update,
>since I added some comments to your patch).

Sure. Please do. I will probably post another one shortly, because I am
still looking at stuff.

Cheers,

Will

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Thu Dec 16 11:08:50 2004