Re: [TSVN] Re: Rev 2089: Please take a close look

Norbert Unterberg wrote:

> Well, I know 20 KB on the stack (TCHAR on a unicode build?) is nothing
> to really worry about (although I would have chosen a CString there
> because of the dynamic texst allocation ... you are using MFC, aren't
> you?). Did you read the second half of my sentence?

Yes, but since you have to pass a buffer to GetErrorMessage(), a CString
wouldn't help much. You'd have to use string.GetBuffer(buffersize) which
would allocate the memory anyway too.

> I believe you do not output the error message at all:
>
> pE->GetErrorMessage(error, 10000);
> CMessageBox::Show(NULL, ERROR, _T("TortoiseSVN"), MB_ICONERROR);
>
> I see you displaying _ERROR_ instead of _error_.

Autsch! That hurts! I guess VisualAssist was too eager to 'correct' the
strings I was typing and I didn't notice that.
Thanks for reporting that!

>> But since I got reports that the update command sometimes just doesn't
>> update at all and _no_ error message is shown, I guess that the
>> pE->ReportError() just doesn't work.
>
> I never had problem with CException::ReportError(), but only if I really
> called it. It can not display an error if you do not call it, and you
> forgot to call it in most of the CFileException handling code ;-)

Yes, in most of the catch{} blocks I didn't report the error. But I
_did_ use pE->ReportError() in the update part, and that's exactly where
people reported that _no_ error message was shown...
So you see, I'm a little bit confused here.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org