[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [TSVN] Rev 2089: Please take a close look

From: SteveKing <steveking_at_gmx.ch>
Date: 2004-12-10 20:05:31 CET

Norbert Unterberg wrote:

> you might want to have a close look at the TSVN changes of rev 2089. I
> guess the code is not exactly what you intended?
> Allocating and fetching a 10K error message on the stack and not even
> using it ... and in line 496 of SVNProgressDlg.cpp you even output two
> message boxes?

10k isn't very much to allocate on the stack. And it only get's
allocated in case of an exception. No exception, no allocation.
The reason for that 'big' buffer is that I don't know how big the error
message might get - better be safe than sorry ;)

Line 496 does output two times the same error message. At least it
should. But since I got reports that the update command sometimes just
doesn't update at all and _no_ error message is shown, I guess that the
pE->ReportError() just doesn't work. I wanted to leave that in just in
case someone runs into this and then could confirm that one or two error
messages are shown.

But I guess I'll remove the pE->ReportError() - reducing the error
message buffer isn't a good idea: the path is included in that message,
and on NT systems that path can be up to 32kB! (So 10k is too small in
that case, but should be sufficient in most cases).


   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Fri Dec 10 20:06:36 2004

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.