Re: [TSVN] Bug in moving externals

Lübbe Onken wrote:

> I did some heavy project restructuring today and I think I discovered a bug
> in TortoiseSVN's handling of externals.
>
> Assume your WC is in myProject, myproject contains a subfolder named "foo"
> Set svn:externals on myProject to "bar http://some/location", commit your
> changes and update your working copy
> You now got
> myProject\foo
> myProject\bar
>
> Right drag "bar" into "foo" and select "move in subversion".
> You'll get a warning about foo not being under version control, but

A warning? And then the moving still goes on?
Looking at the code, I can't find anything which would give you that
behaviour. (TortoiseProc.cpp:874-932).
If the move fails (Subversion doesn't show warnings but only returns
with an error baton which TSVN then shows), an error message is shown
and then the function exits.

> afterwards "foo\bar" is shown as an added folder in windows explorer.
> If you try to "commit" myProject, you'll get a warning about changes to
> externals which have to be committed separately.

The moved dir (still can't see how you got there) is from another
location, therefore you now have a so called 'nested layout'. Maybe the
wording of the warning isn't clear here ('nested layout' instead of
'external'), but the result is actually the same.

> If you try to "revert" myProject, you'll see "foo" as scheduled for deletion
> (including all subdirectories) and "foo/bar" as added.
>
> 1) Why is "foo/bar" not shown as added in the commit dialog? (would be
> acceptable, since it's only a copy)
> 2) What I consider more imortant is that right-drag-moving externals should
> be forbidden. This results in a deletion in one repository and an addition
> in another repository. Dangerous!

Try the same with the CL client, using
'svn move'
if it works, then you know where to report that ;)

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org