[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [TSVN] Header patch

From: SteveKing <stefankueng_at_gmail.com>
Date: 2004-11-03 08:51:10 CET

On Tue, 02 Nov 2004 22:04:24 +0000, Will Dean <svn@indcomp.co.uk> wrote:

> Appended is the monster patch to get everything building speedily with
> pre-compiled headers.
>
> I *think* I have reviewed *every* file in this patch, to see what's
> changed, and there should be nothing other than header changes.
>
> The only 'experimental' stuff is that there is a conditionally-built bit of
> code in ShellExt.cpp, which is my test harness - feel free to delete this
> (and the two extra build configurations) before committing the patch.

I've removed them from the patch when applying.
Committed in revision 1899.

> If you're happy to accept this lot, I'd next like to propose that I raise
> the compiler warning level to W4 throughout, and deal with the issues that
> that raises. This will create another large, bitty, patch, but I think
> would be worthwhile.
>
> I probably won't afflict Lint on us, though I do think it's a good tool...

Well, raising the warning level might be good for once. But keep in
mind that we're using some 'third party' libs which will throw a hell
lot of warnings then...

Stefan

-- 
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Wed Nov 3 08:51:59 2004

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.