[TSVN] Comment on 1895

Hi Stefan,

I've just updated to 1895 - you've done exactly what I intended, but I do
feel we should check that cache timeout mechanism in
SVNFolderStatus::GetCachedItem. I am worried that excessive/uncontrolled
cache lifetime is potentially a nasty problem, especially while we don't
have any cache invalidation mechanism linked from TortoiseProc.

But maybe you have a rationale for omitting the timeout test which I've
missed...?

If you include the timeout test in GetCachedItem, then you can replace all
the cache test code in GetFullStatus with a call to GetCachedItem.

Indeed, if the GetCachedItem call was duplicated into ColumnProvider, we
could drop it from GetFullStatus altogether.

As you've said, this optimisation was for versioned files only, and is
actually a slight pessimisation for unversioned files. We should probably
be checking HasSVNAdminDir early as well, as this can run without doing any
file-system access.

Cheers,

Will

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Tue Nov 2 21:04:13 2004