[TSVN] Question about language DLLs

Hi,

I'm just looking further into 'stuff which TSVN does while refreshing
folders', and I've noticed that it's repeatedly (not for every file, but
perhaps for every subfolder, not really sure) trying to load a DLL from the
languages folder - TortoiseProc1033.dll - I assume that this is, or would
be, the English resources file.

There isn't such a file on my machine, and I assume that a separate DLL
isn't needed for English.

However, this has the effect of defeating the g_ShellCache.GetLangID()
mechanism, because g_langid gets set to zero if a DLL can't be
loaded. This means that it tries this lots of times.
(All this is in ShellExt.cpp)

Would it be possible to change this in some way so that the caching
mechanism applied, even if the file was missing?

There is also some possible scope for improvement in the handling of
missing DLLs - even after GetFileVersionInfoSize has failed on line 114, I
think there is still an attempt made to LoadLibrary the file on line 166,
because versionmatch is initialised to TRUE.

Anyway, it's small stuff, but I thought that it would be nice to publicise
a problem which affects the English version of an application more than the
localised versions...

Cheers,

Will

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Fri Oct 29 01:03:26 2004