[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [TSVN] Another go at a patch for SVNFolderStatus

From: SteveKing <steveking_at_gmx.ch>
Date: 2004-10-28 18:54:21 CEST

Will Dean wrote:

> Here's another go at the same thing, based on Stefan's suggestions.
> I've added the "return &invalidstatus". This does work OK now, but I
> think it might have been slightly more efficient how I had it before (at
> least on my system), because you now get two calls to BuildCache - one
> for the folder, which is now rejected by the return &invalidstatus, and
> one for the first file in the folder, which causes the whole folder to
> get stat'd.
> It is possible to use that first call to get the status, which means
> that the 'first file' then hits on the cache. I doubt there's much in
> it, though.

I'm currently debugging the whole thing here. And as I thought it isn't
that easy. Just checking for folder and then fetching the status
differently (or just returning &invalidstatus) doesn't work. Well it
might for the overlays alone, but there's also the column provider which
has to use the same cache.
The problem you're seeing (fetching the status from a folder above the
one you're actually looking at) comes from the column provider which
calls the status function on the parent folder(!) too. The problem is
that sometimes it asks the parent folder first, but sometimes not. So I
can't just check if the status is requested by the column provider the
first time and then do something else - sometimes the first call of the
column provider is for a 'normal' file/folder and not the parent folder.

About the relative paths: I've asked on the subversion mailing list for
including revision 11439 in 1.1.2. Maybe you guys should kick in there
and 'vote' for that too! With that fix, we won't have to use relative
paths in the shell extension at all, and we won't risk crashes because
of that.


btw: thanks for the patch. I just can't really use it.

   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Thu Oct 28 20:03:43 2004

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.