Re: [TSVN] Slow browsing for shares on a remote machine

Felix Brack wrote:

> I checked out a copy of TSVN's source code; just to see if this would
> help; of course I can not look at the code (even if it's wirtten as
> clean as yours) and then after some hours say: 'there is the
> problem!'.
> I just noticed that the code often uses 'PathIsDirectory' and never uses
> 'PathIsUNC' or 'PathIsUNCServer' or 'PathIsUNCServerShare'. According
> to microsoft, 'PathIsDirectory' returns TRUE if it's argument is a
> directory, else it returns FALSE. In fact 'PathIsDirectory'
> returns 0x10 if it's argument is a directory and 0x1 if it's argument
> is a share. I do not know why the return values differ and I admit,

Are those return values documented somewhere? The MSDN docs only tell
about TRUE and FALSE, but not 0x10 and 0x01.

> that 0x1 as well 0x10 are TRUE (to tell the truth, they are both not
> FALSE). This is why we use the 'PathIsUNC...' functions to get a clear
> distinction between 'directory' and 'share'.
>
> I think, that omitting the request for the '.svn' directory at the
> correct place (???) in TSVN's code would solve my problem.

As of revision 1847, the UNC shares are treated as remote 'drives', even
if they're not mapped to a drive letter. And if you then disabled the
icon overlays for network drives, the slowdown will be gone.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org