[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[TSVN] Re: Patch for SaveAs bug in LogDlg.cpp

From: Simon Large <slarge_at_blazepoint.co.uk>
Date: 2004-09-15 10:31:32 CEST

"SteveKing" wrote:
> > I tried saving the TortoiseBlame icon at rev 1640 to file, out of
curiosity
> > and found a minor naming bug. From ShowLog context menu, Save revision
to
> > file... the name suggested was TortoiseBlame-1640..ico (with double dot
> > before extension).
> >
> > CString.Left(n) and CString.Mid(n) cover the complete string between
them,
> > so there is no need to include a '.' in the Format.
> > The attached patch fixes this.
> >
> > It also changes the condition for putting the revision _after_ the dot:
> >
> > rfind < 0: fred -> fred-rev
> > rfind > 0: fred.txt -> fred-rev.txt
> > rfind == 0: .fred -> .fred-rev (rather than -rev.fred)
>
> Thanks. Tested and applied in revision 1689.
>

The commit comments describe the change from (rfind >= 0) to (rfind > 0),
(ie. what happens in the case of a filename starting with a dot) but that
line is unchanged in the committed rev.

Simon

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Wed Sep 15 13:12:21 2004

This is an archived mail posted to the TortoiseSVN Dev mailing list.