[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[TSVN] must specify log message even if min size is 0

From: Martin Eckardt <Martin.Eckardt_at_micronova.de>
Date: 2004-08-16 16:20:20 CEST

In settings dialog the minimum log size is 0 for testing.
Now if i want commit the OK button is enabled by default, if i enter
something and remove it the button get disabled. I think it's since
1197, i have added a patch also it's only an >= issue.

-- 
____________________________________________________________
MicroNova electronic GmbH
Martin Eckardt
Zentrale Entwicklungsdienste
Unterfeldring 17
D-85256 Vierkirchen
Tel.:	(08139) 93 00-65
Fax.:	(08139) 93 00-80
E-Mail:	Martin.Eckardt@micronova.de
WWW:	http://www.micronova.de
____________________________________________________________

Index: src/TortoiseProc/LogPromptDlg.cpp
===================================================================
--- src/TortoiseProc/LogPromptDlg.cpp (revision 1548)
+++ src/TortoiseProc/LogPromptDlg.cpp (working copy)
@@ -329,7 +329,7 @@
         pDlg->GetDlgItem(IDC_FILLLOG)->EnableWindow(true);
         CString logmsg;
         pDlg->GetDlgItem(IDC_LOGMESSAGE)->GetWindowText(logmsg);
- if (CRegDWORD(_T("Software\\TortoiseSVN\\MinLogSize"), 0) > (DWORD)logmsg.GetLength())
+ if (CRegDWORD(_T("Software\\TortoiseSVN\\MinLogSize"), 0) >= (DWORD)logmsg.GetLength())
         {
                 pDlg->GetDlgItem(IDOK)->EnableWindow(FALSE);
         }
@@ -411,7 +411,7 @@
 {
         CString sTemp;
         GetDlgItem(IDC_LOGMESSAGE)->GetWindowText(sTemp);
- if (DWORD(sTemp.GetLength()) > CRegDWORD(_T("Software\\TortoiseSVN\\MinLogSize"), 0))
+ if (DWORD(sTemp.GetLength()) >= CRegDWORD(_T("Software\\TortoiseSVN\\MinLogSize"), 0))
         {
                 if (!m_bBlock)
                         GetDlgItem(IDOK)->EnableWindow(TRUE);

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: dev-help@tortoisesvn.tigris.org
Received on Mon Aug 16 17:24:38 2004

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.