I agree. Go ahead and remove it. Since the commit was related to
crashes, I am guessing that it was related to the JavaHL hack I
referred to. This is gone, so we do not need that code anyway.
On Mon, Oct 24, 2011 at 2:32 PM, Stephen Elsemore <selsemore_at_collab.net> wrote:
> I can reproduce the problem, and have confirmed that removing the
> cleanProjects code does fix the problem. I'm not sure why it was added
> either (r3722), but I can't imagine any reason not to remove it.
>
>
> On 10/24/11 9:55 AM, "Mark Phippard" <markphip_at_gmail.com> wrote:
>
>> On Mon, Oct 24, 2011 at 12:42 PM, Rich <collabnet.rich_at_xoxy.net> wrote:
>>> Thanks for the quick response. I just did a quick grep of the code to see if
>>> there were any obvious culprits... might SVNUIPlugin.cleanProjects() be the
>>> cause? Admittedly I don't know the code but it seems to be deleting any .svn
>>> folders that sit in the parent folder of a subclipse managed project if they
>>> don't contain a 'text-base' folder, which they won't once they been upgraded
>>> to the SVN 1.7 working copy format.
>>
>> That sounds like a good lead and if nothing else that code should be
>> changed to look for the new folder name. I am not sure why the code
>> exists in the first place. My guess is that is has something to do
>> with the hack we had to do to allow projects to do a single atomic
>> commit. Maybe this code was in place in case Eclipse crashed before
>> the hack cleaned up the .svn folder it created? SVN can do this
>> natively now so we no longer need the hack so maybe this code can be
>> removed.
>>
>
> ------------------------------------------------------
> http://subclipse.tigris.org/ds/viewMessage.do?dsForumId=1047&dsMessageId=2862475
>
> To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_subclipse.tigris.org].
>
--
Thanks
Mark Phippard
http://markphip.blogspot.com/
------------------------------------------------------
http://subclipse.tigris.org/ds/viewMessage.do?dsForumId=1047&dsMessageId=2862483
To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_subclipse.tigris.org].
Received on 2011-10-24 20:47:27 CEST