[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: [Subclipse-users] i can't delete folders (and commit them) in Subclipse 1.7

From: Stephen Elsemore <selsemore_at_collab.net>
Date: Mon, 22 Aug 2011 07:47:24 -0700

Hi Johan,

The main problem was that our move/delete hook (SVNMoveDeleteHook) was not notifying the Eclipse resource tree that it had deleted the folder, so we weren't seeing the deletion reflected in the workspace. I've committed a fix for this, and also for the problem that was causing the Synchronize view to not refresh after the deleted folder was committed. Does Cleanup resolve the current problem with your working copy?

Thanks,
Steve

p.s.
We decided to always show Team->Upgrade and show an error message if it is selected against a folder that has already been upgraded, rather than disabling or not showing the option. This is to avoid the overhead of an API call when the context menu is shown.

-----Original Message-----
From: jcompagner [mailto:jcompagner_at_gmail.com]
Sent: Monday, August 22, 2011 3:14 AM
To: users_at_subclipse.tigris.org
Subject: Re: [Subclipse-users] i can't delete folders (and commit them) in Subclipse 1.7

hmm after a restart it is even worse, then Team->Revert on the project also doesn't show up the deleted dirs.
And i don't see that weird synchronize view entry. So now it seems to be completely gone..

in the log i see entries like this:

!ENTRY org.tigris.subversion.subclipse.core 4 368 2011-08-22 12:11:50.139 !MESSAGE Resource '/eclipse_target/ship_plugins/features/org.eclipse.dltk.core.servoy_3.0.0.201108041240'
does not exist.
!STACK 1
org.eclipse.core.internal.resources.ResourceException: Resource '/eclipse_target/ship_plugins/features/org.eclipse.dltk.core.servoy_3.0.0.201108041240'
does not exist.
        at org.eclipse.core.internal.resources.Resource.checkExists(Resource.java:320)
        at org.eclipse.core.internal.resources.Resource.checkAccessible(Resource.java:194)
        at org.eclipse.core.internal.resources.Synchronizer.setSyncInfo(Synchronizer.java:244)
        at org.tigris.subversion.subclipse.core.status.SynchronizerSyncInfoCache$SyncInfoSynchronizedAccessor.flushPendingCacheWrites(SynchronizerSyncInfoCache.java:260)
        at org.tigris.subversion.subclipse.core.status.SynchronizerSyncInfoCache$1.run(SynchronizerSyncInfoCache.java:205)
        at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2344)
        at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2326)
        at org.tigris.subversion.subclipse.core.status.SynchronizerSyncInfoCache.flushPendingStatuses(SynchronizerSyncInfoCache.java:203)
        at org.tigris.subversion.subclipse.core.status.StatusCacheManager$2.run(StatusCacheManager.java:368)
        at org.tigris.subversion.subclipse.core.util.JobUtility$1$1.run(JobUtility.java:22)
        at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2344)
        at org.tigris.subversion.subclipse.core.util.JobUtility$1.run(JobUtility.java:20)
        at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)

On Mon, Aug 22, 2011 at 12:05, Johan Compagner <jcompagner_at_gmail.com> wrote:
> I am using the latest 1.7 (from the 1.8 url)
>
> and when i delete i see this in the log:
>
> delete --force
> C:/workspace60/eclipse_target/ship_plugins/features/org.eclipse.dltk.c
> ore.servoy.source_3.0.0.201108041240
>    D        
> C:/workspace60/eclipse_target/ship_plugins/features/org.eclipse.dltk.c
> ore.servoy.source_3.0.0.201108041240
>    D        
> C:/workspace60/eclipse_target/ship_plugins/features/org.eclipse.dltk.c
> ore.servoy.source_3.0.0.201108041240/eclipse_update_120.jpg
>    D        
> C:/workspace60/eclipse_target/ship_plugins/features/org.eclipse.dltk.c
> ore.servoy.source_3.0.0.201108041240/epl-v10.html
>    D        
> C:/workspace60/eclipse_target/ship_plugins/features/org.eclipse.dltk.c
> ore.servoy.source_3.0.0.201108041240/feature.properties
>    D        
> C:/workspace60/eclipse_target/ship_plugins/features/org.eclipse.dltk.c
> ore.servoy.source_3.0.0.201108041240/feature.xml
>    D        
> C:/workspace60/eclipse_target/ship_plugins/features/org.eclipse.dltk.c
> ore.servoy.source_3.0.0.201108041240/license.html
> delete --force
> C:/workspace60/eclipse_target/ship_plugins/features/org.eclipse.dltk.j
> avascript.servoy.source_3.0.0.201108041240
>    D        
> C:/workspace60/eclipse_target/ship_plugins/features/org.eclipse.dltk.j
> avascript.servoy.source_3.0.0.201108041240
>    D        
> C:/workspace60/eclipse_target/ship_plugins/features/org.eclipse.dltk.j
> avascript.servoy.source_3.0.0.201108041240/eclipse_update_120.jpg
>    D        
> C:/workspace60/eclipse_target/ship_plugins/features/org.eclipse.dltk.j
> avascript.servoy.source_3.0.0.201108041240/epl-v10.html
>    D        
> C:/workspace60/eclipse_target/ship_plugins/features/org.eclipse.dltk.j
> avascript.servoy.source_3.0.0.201108041240/feature.properties
>    D        
> C:/workspace60/eclipse_target/ship_plugins/features/org.eclipse.dltk.j
> avascript.servoy.source_3.0.0.201108041240/feature.xml
>    D        
> C:/workspace60/eclipse_target/ship_plugins/features/org.eclipse.dltk.j
> avascript.servoy.source_3.0.0.201108041240/license.html
> delete --force
> C:/workspace60/eclipse_target/ship_plugins/features/org.eclipse.dltk.c
> ore.servoy_3.0.0.201108041240
>    D        
> C:/workspace60/eclipse_target/ship_plugins/features/org.eclipse.dltk.c
> ore.servoy_3.0.0.201108041240
>    D        
> C:/workspace60/eclipse_target/ship_plugins/features/org.eclipse.dltk.c
> ore.servoy_3.0.0.201108041240/eclipse_update_120.jpg
>    D        
> C:/workspace60/eclipse_target/ship_plugins/features/org.eclipse.dltk.c
> ore.servoy_3.0.0.201108041240/epl-v10.html
>    D        
> C:/workspace60/eclipse_target/ship_plugins/features/org.eclipse.dltk.c
> ore.servoy_3.0.0.201108041240/feature.properties
>    D        
> C:/workspace60/eclipse_target/ship_plugins/features/org.eclipse.dltk.c
> ore.servoy_3.0.0.201108041240/feature.xml
>    D        
> C:/workspace60/eclipse_target/ship_plugins/features/org.eclipse.dltk.c
> ore.servoy_3.0.0.201108041240/license.html
> delete --force
> C:/workspace60/eclipse_target/ship_plugins/features/org.eclipse.dltk.j
> avascript.servoy_3.0.0.201108041240
>    D        
> C:/workspace60/eclipse_target/ship_plugins/features/org.eclipse.dltk.j
> avascript.servoy_3.0.0.201108041240
>    D        
> C:/workspace60/eclipse_target/ship_plugins/features/org.eclipse.dltk.j
> avascript.servoy_3.0.0.201108041240/eclipse_update_120.jpg
>    D        
> C:/workspace60/eclipse_target/ship_plugins/features/org.eclipse.dltk.j
> avascript.servoy_3.0.0.201108041240/epl-v10.html
>    D        
> C:/workspace60/eclipse_target/ship_plugins/features/org.eclipse.dltk.j
> avascript.servoy_3.0.0.201108041240/feature.properties
>    D        
> C:/workspace60/eclipse_target/ship_plugins/features/org.eclipse.dltk.j
> avascript.servoy_3.0.0.201108041240/feature.xml
>    D        
> C:/workspace60/eclipse_target/ship_plugins/features/org.eclipse.dltk.j
> avascript.servoy_3.0.0.201108041240/license.html
>    D        
> C:/workspace60/eclipse_target/ship_plugins/features/org.eclipse.dltk.c
> ore.servoy_3.0.0.201108041240/eclipse_update_120.jpg
>
> I don't see the directories really disappearing, only when a manual or
> auto refresh happens they are gone.
> (so that is one bug in my eyes)
>
> And then in the synchronize view, i don't see them as out going
> changes. but as a weird entry like:
>
> -1 [SynchronizeView.noAuthor] (n/a)
>
> and under that i see incoming additions of what i just deleted..
> Updating that does nothing.
>
> And i don't see those files as outgoing deletions in the sync view
>
> Also when i click on the project and just say: Commit
>
> In that window they are not appearing...So i can't really commit by
> deletion at all
>
> If i do Revert on that project i do see them, and i can revert them..
> If i revert them, and then delete again, i get exactly the same thing.
>
> johan
>
> P.S. Team->Upgrade should be gone or disabled when it is already upgraded..
>

------------------------------------------------------
http://subclipse.tigris.org/ds/viewMessage.do?dsForumId=1047&dsMessageId=2827368

To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_subclipse.tigris.org].

------------------------------------------------------
http://subclipse.tigris.org/ds/viewMessage.do?dsForumId=1047&dsMessageId=2827618

To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_subclipse.tigris.org].
Received on 2011-08-22 16:47:43 CEST

This is an archived mail posted to the Subclipse Users mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.