[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Subclipse-users] [Subclipse-dev] Edit while commit

From: Stephen Elsemore <selsemore_at_collab.net>
Date: Tue, 14 Dec 2010 09:57:02 -0800

Since it is easy to use the Synchronize view to see which resources are
ready to be committed, and to perform editable compares on those resources
if necessary prior to committing, my feeling is that it's not worth changing
the commit dialog.

It would be fairly simple to make the compare from the commit dialog bring
up a modal compare dialog with Save/Cancel buttons, similar to what
Mercurial does. But this would probably have to be a preference, in case
there are some who prefer the current built-in compare pane, which would
just add to preference clutter.

Likewise, it would not be difficult to make the built-in compare editable.
But with this approach, as Mark alluded to, the edit/save cycle gets
complicated. For example, if you double-click on resource and make changes
in the compare pane, then double-click a different resource, would you
prompt to save the changes to the first resource before opening the second

On 12/14/10 6:54 AM, "Mikhail Barg" <mba_at_cosmigo.ru> wrote:

> On 14.12.2010 17:47, Mark Phippard wrote:
>> What does Mercurial do to indicate a save is needed? Does it just
>> save changes without asking?
> In Mercurial the compare dialog is separate from commit dialog as it has
> been some time before in Subclipse.
> So they have two buttons "Save changes" and "Cancel" to close the
> dialog. "Save changes" is only enabled when you have made some changes.


To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_subclipse.tigris.org].
Received on 2010-12-14 18:53:30 CET

This is an archived mail posted to the Subclipse Users mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.