this does not work when you cancel the dialog. So dont really commit
Maybe this is a nice patch so that we dont only store the messages on
the actual commit but when we close the dialog through any way
possible
johan
On Sun, Dec 12, 2010 at 19:54, Stephen Elsemore <selsemore_at_collab.net> wrote:
> Have you noticed that if you type in a commit message, then close the dialog
> because you realize you missed something, then bring back the dialog, the
> uncommitted comment that you typed previously is available in the previous
> comments dropdown? So you can at least avoid the copy-paste.
>
>
> On 12/12/10 9:58 AM, "Andreas Haferburg" <haferbur_at_inf.fu-berlin.de> wrote:
>
>> Mark, the point of the original mail was that the commit dialog is modal
>> and doesn't allow to make any changes to the files you want to commit,
>> and that this is bad. Why does it have to be modal?
>>
>> In about 80% of the cases when I want to commit something I curse at
>> that dialog. I use it to go through all the changes one last time. It
>> always gets in the way when I discover that I forgot something, and I
>> end up copy-pasting the commit message to vim, closing the dialog, edit
>> some files in Eclipse, bring back the commit dialog, copy-paste from
>> vim. Just because I'm not allowed to minimize that friggin dialog. One
>> of the biggest annoyances in Subclipse.
>>
>> Have you never noticed that you forgot something after bringing up that
>> commit dialog?
>>
>> Best regards
>> Andreas
>>
>>
>>
>>
>> On 12/12/2010 6:09 PM, Mark Phippard wrote:
>>> On Sun, Dec 12, 2010 at 11:58 AM, surya kamal kiran kuchibhotla
>>> <kamal.kuchibhotla_at_gmail.com> wrote:
>>>
>>>> This is the first email to Subclipse so if I am not doing something properly
>>>> here, please forgive me and point out the right thing/way to do it.
>>>> I have been happily using Subclipse plugin on latest versions of Eclipse
>>>> (3.2, 3.3 etc.. on Windows XP OS) for a while now.
>>>> I have an enchancement that I thought would be really nice to have.
>>>> A lot of times, I want to commit small changes to files from the package
>>>> explorer. But before i commit in the diff pane, I want to make certain
>>>> changes like adding a comment etc.... In order to do this, i need to come
>>>> out that dialog, change the file and commit again which is not so
>>>> productive.
>>>> I also use TortoiseSVN on the file system and it lets you edit the files
>>>> while committing and its really convenient.
>>>> Is there any way to do this in Subclipse itself so that i don't have to
>>>> switch to TortoiseSVN everytime ?
>>>
>>> Why would you need to switch to TortoiseSVN to edit the file?
>>>
>>>> I think I can edit these files from the Synchronize view but i feel like its
>>>> quick to do this from any commit dialog without going to the Sync view.
>>>> I am sure some of you have already thought about it but I couldn't find any
>>>> issue in the tracker about this.
>>>> Please let me know if this is already discussed somewhere and if I missed
>>>> any issue.
>>>
>>> I do not think it makes sense to allow someone to edit the file
>>> content from the dialog, sorry. In any case, the commit dialog is
>>> modal and the Eclipse text editors all run beneath it, so there would
>>> be no way to add this anyway.
>>>
>>>> If not, I am a developer interested in contributing this item to the
>>>> baseline.
>>>> Can somebody point out to me where to get started?
>>>
>>> There is some information on getting started with development in the wiki:
>>>
>>> http://subclipse.tigris.org/wiki/SubclipseDevelopment
>>>
>>> --
>>> Thanks
>>>
>>> Mark Phippard
>>> http://markphip.blogspot.com/
>>>
>>> ------------------------------------------------------
>>> http://subclipse.tigris.org/ds/viewMessage.do?dsForumId=1047&dsMessageId=2690
>>> 151
>>>
>>> To unsubscribe from this discussion, e-mail:
>>> [users-unsubscribe_at_subclipse.tigris.org].
>>
>
> ------------------------------------------------------
> http://subclipse.tigris.org/ds/viewMessage.do?dsForumId=1047&dsMessageId=2690191
>
> To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_subclipse.tigris.org].
>
------------------------------------------------------
http://subclipse.tigris.org/ds/viewMessage.do?dsForumId=1047&dsMessageId=2690366
To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_subclipse.tigris.org].
Received on 2010-12-13 13:23:35 CET