i looked at the code
and the problem is that 2 checkboxes we have there
keep locks and show unversioned files
and that later one is invisible if there are no unversioned files selected
But it does take up space
toolbarManager.add(new ControlContribution("ignoreUnversioned") {
//$NON-NLS-1$
protected Control createControl(Composite parent) {
includeUnversionedButton = new Button(parent, SWT.CHECK);
includeUnversionedButton.setText(Policy.bind("CommitDialog.includeUnversioned"));
//$NON-NLS-1$
because it is quite a big string that CommitDialog.includeUnversioned
I think those 2 checkboxes should be nice visual image buttons with tooltips
instead of texts
so that they are not take up so much space and the buttons dont disappear so
quick
johan
2009/9/7 Miha Vitorovic <mvitorovic_at_nil.com>
>
> Oh, yes I understand why the compare is there and I use it that way. But I
> still dislike narrow columns - it's a "visual" thing. Anyhow... it's fine
> the way as it is, since all this is turning more and more into a bikeshed
> discussion :)
>
> Thanks for your great work Mark.
>
> Br,
> ---
> Miha Vitorovic
> Inženir v tehničnem področju
> Customer Support Engineer
>
> NIL Data Communications, Tivolska cesta 48, 1000 Ljubljana, Slovenia
> Phone +386 1 4746 500 Fax +386 1 4746 501 http://www.NIL.si<http://www.nil.si/>
>
>
> From: Mark Phippard <markphip_at_gmail.com>
> To: users_at_subclipse.tigris.org Date: 07.09.2009 15:28
> Subject: Re: [Subclipse-users] The new "compare on commit" UI
>
> ------------------------------
>
>
>
> The main idea behind providing access to a diff is so that you can use
> it to help type your commit message. The old system required you to
> open/close the diff to do this. With the new dialog you can do them
> both. If you want to review your diff why not do that from the
> Synchronize view before you take the commit option?
>
>
> 2009/9/7 Miha Vitorovic <mvitorovic_at_nil.com>:
> >
> > Sorry,
> >
> > to see more diff context I must have resized my dialog like this:
> >
> >
> >
> > and then forgot that it was me who has done it. Anyhow, it would be great
> if
> > there was a button to close the preview without having to resize again,
> > since inspecting diff in very narrow columns doesn't quite "do it" for
> me.
> >
> > P.S. I liked the old style better, since it gave me the ability to view
> the
> > diff in full screen mode.
> >
> > Br,
> > ---
> > Miha Vitorovic
> > Inženir v tehničnem področju
> > Customer Support Engineer
> >
> > NIL Data Communications, Tivolska cesta 48, 1000 Ljubljana, Slovenia
> > Phone +386 1 4746 500 Fax +386 1 4746 501 http://www.NIL.si<http://www.nil.si/>
> >
> >
> > From: Mark Phippard <markphip_at_gmail.com>
> > To: users_at_subclipse.tigris.org
> > Date: 07.09.2009 14:35
> > Subject: Re: [Subclipse-users] The new "compare on commit" UI
> > ________________________________
> >
> >
> > 2009/9/7 Miha Vitorovic <mvitorovic_at_nil.com>:
> >
> >> could you maybe move the "Show file content changes pane" button more to
> >> the
> >> left, since the pane in question successfully hides it, when it is open.
> I
> >> like to inspect the changes, sure, but I also like to close the preview,
> >> once I'm done.
> >
> > I do not understand. When I do it, it is all a single dialog so
> > nothing is hidden and I can click the button to hide the section
> > again.
> >
> >
> >
>
>
>
------------------------------------------------------
http://subclipse.tigris.org/ds/viewMessage.do?dsForumId=1047&dsMessageId=2392130
To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_subclipse.tigris.org].
Received on 2009-09-07 21:15:56 CEST