Mark,
I talked this over with my team, and we really like the Mylyn-related solution that you propose. We'll be working to implement that simplification across the team.
Two things I want to leave you with:
1) The behavior issue that I am seeing appears to be related to the atomic commit behavior that we discussed last August, and that you fixed in bug 783. It still seems very odd to me that the behavior is inconsistent.
2) In the cases where Subclipse correctly detects the bugtraq properties, there is a minor problem with the URL it builds. Our bug format is "Issue Number %BUGID%:\n", and when Subclipse displays the hyperlink in the history view, it includes the ":" as part of the link (TortoiseSVN does not do this). The resulting link tells me that bug "355:" does not exist. Is this an issue with Subclipse?
Thanks again for all the assistance!
Michael Schechter
mschechter_at_national.aaa.com
RESPONSESupport_at_national.aaa.com
-----Original Message-----
From: Mark Phippard [mailto:markphip_at_gmail.com]
Sent: Monday, March 30, 2009 2:24 PM
To: users_at_subclipse.tigris.org
Subject: Re: [Subclipse-users] Question about bugtraq properties
This is the class that does most of the work if you want to look at a patch.
http://subclipse.tigris.org/source/browse/subclipse/trunk/subclipse/org.tigris.subversion.subclipse.ui/src/org/tigris/subversion/subclipse/ui/settings/ProjectProperties.java?view=log
I was wrong in my followup response last week. This code uses Eclipse
classes to walk the tree so it cannot walk past the project root. We
made some other change where we try to retrieve the properties without
checking if the item is managed by SVN, and we just handle the
exceptions. This was to fix the issue I referenced.
If you are using Mylyn why do you even want to use this feature?
Mylyn gives the same results with a better overall workflow. You can
edit the Mylyn log message template to match whatever you'd normally
type in TortoiseSVN.
Mark
On Mon, Mar 30, 2009 at 2:01 PM, Schechter, Michael
<MSchechter_at_national.aaa.com> wrote:
> Mark,
>
> The places where I can duplicate this include a pair of projects that are siblings in the file system - they have exactly the same parent path. Your proposed solution could become a maintenance problem for us, as we add new projects semi-regularly, and this would be an extra complication. I know that auto-props does not yet support directories, so we will be looking into tsvn:auto-props as a possible solution.
>
> The way I am using Subversion (with the workspace within the checked-out tree yet parallel to the code/projects) was based on several white papers documenting best practices for integrating Rational (now IBM) ClearCase and Eclipse. Is there any similar documentation available for Subversion/Subclipse that provides a recommended model?
>
> Thanks!
>
> Michael Schechter
> mschechter_at_national.aaa.com
> RESPONSESupport_at_national.aaa.com
> -----Original Message-----
> From: Mark Phippard [mailto:markphip_at_gmail.com]
> Sent: Friday, March 27, 2009 6:14 PM
> To: users_at_subclipse.tigris.org
> Subject: Re: [Subclipse-users] Question about bugtraq properties
>
> Actually, for this one feature alone we did implement support for
> crawling the filesystem outside of Eclipse. See:
>
> http://subclipse.tigris.org/issues/show_bug.cgi?id=670
>
> It not to make the feature better though, it was to fix a potential
> performance issue. Since it works for you in some places and not
> others, I am guessing there must be something in the code that
> triggers it to stop searching before it hits the properties. Not sure
> what that'd be, perhaps an unversioned folder is hit in one scenario
> and not the other?
>
> Mark
>
>
> On Fri, Mar 27, 2009 at 6:06 PM, Mark Phippard <markphip_at_gmail.com> wrote:
>> This is what I said originally was the problem. Subclipse never walks
>> the tree higher than the Eclipse project. Anything about that on the
>> underlying filesystem is never accessed by Subclipse. TortoiseSVN
>> works in the filesystem, not Eclipse's view of it. So it would walk
>> to the root of the working copy.
>>
>> Your solution would be to put the properties on the project root
>> folders as opposed to their parent.
>>
>> Mark
>>
>>
>> On Fri, Mar 27, 2009 at 5:37 PM, Schechter, Michael
>> <MSchechter_at_national.aaa.com> wrote:
>>> Mark,
>>>
>>> There appears to be a problem with walking the tree to the repository root in search of the bugtraq properties. I have a number of projects in my workspace, and most of them fail to display the issue number box on commit.
>>>
>>> Here's what I see: I exported the bugtraq properties as a set from /project/trunk/foo and imported them into one of these project directories (the directory where .classpath and .project live). Suddenly, I got the issue number box when I tried to commit changes in that project.
>>>
>>> Also, the issue number box appears consistently from TortoiseSVN at all locations in /project/trunk/foo without the need to add the bugtraq properties at any other level. This problem only exists inside Eclipse when using Subclipse. From everything you've said (and written elsewhere), I understood that there should be no difference in bugtraq-based property behavior between TortoiseSVN and Subclipse. In my particular instance, that does not appear to be the case. If I had set the properties incorrectly (certainly a possibility), I would expect it not to work from TortoiseSVN as well.
>>>
>>> Any suggestions?
>>>
>>> Thanks!
>>>
>>> Michael Schechter
>>> mschechter_at_national.aaa.com
>>> RESPONSESupport_at_national.aaa.com
>>>
>>> -----Original Message-----
>>> From: Mark Phippard [mailto:markphip_at_gmail.com]
>>> Sent: Friday, March 27, 2009 4:37 PM
>>> To: users_at_subclipse.tigris.org
>>> Subject: Re: [Subclipse-users] Question about bugtraq properties
>>>
>>> On Fri, Mar 27, 2009 at 4:30 PM, Schechter, Michael
>>> <MSchechter_at_national.aaa.com> wrote:
>>>> Mark,
>>>>
>>>> /trunk/foo does not live in my workspace. My workspace lives parallel to /trunk/foo.
>>>>
>>>> My structure is:
>>>> /project
>>>> /trunk
>>>> /eclipse (workspace lives here, only has references to projects as we don't copy into workspace)
>>>> /foo (Eclipse projects/code live here)
>>>>
>>>> Also, we import all projects from the "foo" tree, rather than checking out into the workspace.
>>>
>>> I still do not really understand this part. Not sure I need to.
>>>
>>>> As of now, the "Issue #" prompt is working correctly from both the package and project explorer
>>>> views within the Java perspective. Given that you say this should not work, I am very confused.
>>>
>>> When did I say that! I am quite certain I did not. It should work
>>> from everywhere.
>>>
>>>> This does not match to any of the attempts I have made to start a commit, and instead seems to
>>>> be related to Eclipse software updates. I was able to determine that a similar block was written
>>>> when I checked for Mylyn updates.
>>>
>>> Yes, nothing to do with Subclipse.
>>>
>>>> org.tigris.subversion.subclipse.graph.popup.actions.SynchronizeViewGraphAction
>>>> !STACK 0
>>>> java.lang.NullPointerException
>>>
>>> This might be causing problem, but it is not directly related. It is
>>> just determining whether to show the Revision Graph option. The
>>> latest version of the Revision Graph plugin fixes this. You can try
>>> it.
>>>
>>> --
>>> Thanks
>>>
>>> Mark Phippard
>>> http://markphip.blogspot.com/
>>>
>>> ------------------------------------------------------
>>> http://subclipse.tigris.org/ds/viewMessage.do?dsForumId=1047&dsMessageId=1448306
>>>
>>> To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_subclipse.tigris.org].
>>>
>>>
>>> This communication (including all attachments) is intended solely for
>>> the use of the person(s) to whom it is addressed and should be treated
>>> as a confidential AAA communication. If you are not the intended
>>> recipient, any use, distribution, printing, or copying of this email is
>>> strictly prohibited. If you received this email in error, please
>>> immediately delete it from your system and notify the originator. Your
>>> cooperation is appreciated.
>>>
>>> ------------------------------------------------------
>>> http://subclipse.tigris.org/ds/viewMessage.do?dsForumId=1047&dsMessageId=1448892
>>>
>>> To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_subclipse.tigris.org].
>>
>>
>>
>> --
>> Thanks
>>
>> Mark Phippard
>> http://markphip.blogspot.com/
>>
>
>
>
> --
> Thanks
>
> Mark Phippard
> http://markphip.blogspot.com/
>
> ------------------------------------------------------
> http://subclipse.tigris.org/ds/viewMessage.do?dsForumId=1047&dsMessageId=1449271
>
> To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_subclipse.tigris.org].
>
>
> This communication (including all attachments) is intended solely for
> the use of the person(s) to whom it is addressed and should be treated
> as a confidential AAA communication. If you are not the intended
> recipient, any use, distribution, printing, or copying of this email is
> strictly prohibited. If you received this email in error, please
> immediately delete it from your system and notify the originator. Your
> cooperation is appreciated.
>
> ------------------------------------------------------
> http://subclipse.tigris.org/ds/viewMessage.do?dsForumId=1047&dsMessageId=1484321
>
> To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_subclipse.tigris.org].
--
Thanks
Mark Phippard
http://markphip.blogspot.com/
------------------------------------------------------
http://subclipse.tigris.org/ds/viewMessage.do?dsForumId=1047&dsMessageId=1484526
To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_subclipse.tigris.org].
This communication (including all attachments) is intended solely for
the use of the person(s) to whom it is addressed and should be treated
as a confidential AAA communication. If you are not the intended
recipient, any use, distribution, printing, or copying of this email is
strictly prohibited. If you received this email in error, please
immediately delete it from your system and notify the originator. Your
cooperation is appreciated.
------------------------------------------------------
http://subclipse.tigris.org/ds/viewMessage.do?dsForumId=1047&dsMessageId=1496712
To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_subclipse.tigris.org].
Received on 2009-03-31 17:19:55 CEST