[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Subclipse-users] Annoying prompt on revert

From: Mark Phippard <markphip_at_gmail.com>
Date: Tue, 1 Jul 2008 08:30:43 -0400

On Tue, Jul 1, 2008 at 2:12 AM, Dan Fabulich <dan_at_fabulich.com> wrote:
> There's an issue that has annoyed me about Subclipse for a long time. Open
> up a file in the Java editor, edit it, save it. Right click in the editor,
> Team -> Revert. The SVN "Revert" dialog will appear; click OK.
> Now, annoyingly, Eclipse will pop-up a "File Changed" dialog, saying: "The
> file has changed on the file system. Do you want to replace the editor
> contents with these changes?"
> I certainly *do* want to load up the reverted file; that's why I said
> "Revert" after all! I wish there were some way to make Eclipse not ask me
> that; the CVS team provider does not have this problem.
> I think the magic is to pass IWorkspace.AVOID_UPDATE to IWorkspace.run,
> which we apparently usually do, but not in every case, e.g. not in
> SynchronizerSyncInfoCache.
> Should I file an issue in the tracker?

I'd say only if you can attach a tested patch. I think the difference
is that Subversion modifies the file from native code and then the
notification is sent through Eclipse by us. When CVS does it, it is
likely using Eclipse API's for all modifications and Eclipse probably
handles it more gracefully.

This is one where I'd rather not make a change unless we have good
reason to know it is the right change. Especially since we do not
have a regression test suite to rely on.

Mark Phippard
To unsubscribe, e-mail: users-unsubscribe_at_subclipse.tigris.org
For additional commands, e-mail: users-help_at_subclipse.tigris.org
Received on 2008-07-01 14:30:59 CEST

This is an archived mail posted to the Subclipse Users mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.