[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Subclipse-users] Prompting when committing warnings/errors

From: Dan Fabulich <dan_at_fabulich.com>
Date: Mon, 30 Jun 2008 21:54:45 -0700 (Pacific Daylight Time)

Mark Phippard wrote:

> Yes, you can file an enhancement in the tracker. We'd just need to
> know the code to run to check this and it could not require us to add
> any onerous new plug-in dependencies.

Filed as issue 766. The code to check this is trivial: IResource has a
"findMaxProblemSeverity" function as of Eclipse 3.3 Europa. In the CVS
CommitWizard it just loops over every IResource about to be checked in and
calls that function.

> Other than that, someone just needs to write the code. Sounds like a
> good patch.

I think this is one of those cases where writing the feature would be a
matter of seconds, but implementing a preferences UI for prompting might
require a bit more work. CVS has two tri-state preferences:

   Commit resources with warnings: Yes / No / Prompt (default Yes)
   Commit resources with errors: Yes / No / Prompt (default Prompt)

Though, come to think of it, that may be overkill. After all, if you
really want to check in the file regardless, you can just change the
preference, so "No" really means "Prompt me to open the preferences

It might be better to just have a single tri-state preference:

   Warn before commit

* Warn before committing resources with problems
* Warn only about errors
* Never warn before commit

Additionally, the "Are you sure?" dialog should probably have a "Never ask
me this again" checkbox.


To unsubscribe, e-mail: users-unsubscribe_at_subclipse.tigris.org
For additional commands, e-mail: users-help_at_subclipse.tigris.org
Received on 2008-07-01 06:55:10 CEST

This is an archived mail posted to the Subclipse Users mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.