[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: [Subclipse-users] Colorized decoration update

From: Daniel Mace <daniel.mace_at_benefitfocus.com>
Date: 2006-08-31 14:35:41 CEST

I've never seen the CVS code, but I will check it out. Thanks for the
reference. I have only patched eclipse plugins twice in my life, this
being the second. :)

I will get that account and see how the CVS plugin manages this. Thanks
again!

Daniel Mace
Senior Software Engineer
Benefitfocus.com, Inc.
627 Johnnie Dodds Blvd.
Mt. Pleasant, SC 29464
(843) 849-7476 ext. 393
(843) 849-9485 (fax)

-----Original Message-----
From: Mark Phippard [mailto:markp@softlanding.com]
Sent: Wednesday, August 30, 2006 6:46 PM
To: users@subclipse.tigris.org
Subject: Re: [Subclipse-users] Colorized decoration update

"Daniel Mace" <daniel.mace@benefitfocus.com> wrote on 08/30/2006
05:14:49
PM:

> I have made a simple modification to
> org.tigris.subversion.subclipse.ui.decorator.SVNDecoratorConfiguration
> which defines a static "map" (well, a 2D string array, for the purpose

> of speed) between the flags and colorization keys which I defined in
> the plugin.xml. For instance, SVNDecoratorConfiguration.DIRTY_FLAG
> ->svn_dirty_foreground. Following text decoration, I loop through the
> defined color mappings, and determine if the flag for that key is
> contained in the bindings map passed into the decorator methods. If
> so, I look up the user defined color using
> PlatformUI.getWorkbench().getThemeManager().getCurrentTheme().getColor
> Re
> gistry() and apply it to the decorator.
>
> I defined preferences and mappings for dirty, added, and external
> resources to begin with. The colors are configurable under the SVN
> category in Prefs->General->Appearance->Fonts and Colors.
>
> It's working very well for private use. No idea if the approach is
> ideal, but it certainly works. Is there somewhere I can submit the
> code for review?

Attach it to that issue I sent you in the issue tracker. You just have
to create a tigris.org account and then request the Observer role in our
project.

Ideally, you should look at how CVS implemented the feature and copy
them.
 For all I know, that is what you did, but if you did, you should say
so.

Thanks

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subclipse.tigris.org
For additional commands, e-mail: users-help@subclipse.tigris.org

****************************************************************************************
BENEFITFOCUS.COM CONFIDENTIALITY NOTICE: This electronic message is intended only for the individual or entity to which it is addressed and may contain information that is confidential and protected by law. Unauthorized review, use, disclosure, or dissemination of this communication or its contents in any way is prohibited and may be unlawful. If you are not the intended recipient or a person responsible for delivering this message to an intended recipient, please notify the original sender immediately by e-mail or telephone, return the original message to the original sender or to bfpostmaster@benefitfocus.com, and destroy all copies or derivations of the original message. Thank you. (BFeComNote Rev. 08/01/2005)
***************************************************************************************

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subclipse.tigris.org
For additional commands, e-mail: users-help@subclipse.tigris.org
Received on Thu Aug 31 14:34:55 2006

This is an archived mail posted to the Subclipse Users mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.