Mark Phippard wrote:
>> Mark, have you had a chance to look at the FindBugs reports I've sent
>>few days ago?
>>
>> There was some potention NPE's and some of the if's that are always
>>false... See reports for details.
>>
>>
>No, I would suggest you just start submitting small patches for the
>various issues.
>
>
Actually those were tricky ones. I can't really say how it suppose to
be (especially when if were always true):
next two always false!
BIT: Incompatible bit masks yield a constant result in
org.tigris.subversion.subclipse.core.resources.BaseFolder.members(org.eclipse.core.runtime.IProgressMonitor,int)
BaseFolder.java
org.tigris.subversion.subclipse.core/src/org/tigris/subversion/subclipse/core/resources
line 77
BIT: Incompatible bit masks yield a constant result in
org.tigris.subversion.subclipse.core.resources.RemoteFolder.members(org.eclipse.core.runtime.IProgressMonitor,int)
RemoteFolder.java
org.tigris.subversion.subclipse.core/src/org/tigris/subversion/subclipse/core/resources
line 217
This one probably has missing curly brackets:
NP: Possible null pointer dereference in
org.tigris.subversion.subclipse.core.commands.CheckoutCommand.refreshProject(org.eclipse.core.resources.IProject,org.eclipse.core.runtime.IProgressMonitor)
CheckoutCommand.java
org.tigris.subversion.subclipse.core/src/org/tigris/subversion/subclipse/core/commands
line 283
memberResource can be null
NP: Possible null pointer dereference in
org.tigris.subversion.subclipse.core.sync.notused.SVNRemoteTree.fetchVariant(org.eclipse.core.resources.IResource,int,org.eclipse.core.runtime.IProgressMonitor)
SVNRemoteTree.java
org.tigris.subversion.subclipse.core/src/org/tigris/subversion/subclipse/core/sync/notused
line 140
if it would be null we have got NPE in above line
RCN: Redundant comparison to null in
org.tigris.subversion.subclipse.core.status.SynchronizerSyncInfoCache.addStatus(org.tigris.subversion.subclipse.core.resources.LocalResourceStatus)
SynchronizerSyncInfoCache.java
org.tigris.subversion.subclipse.core/src/org/tigris/subversion/subclipse/core/status
line 55
NP: Possible null pointer dereference in
org.tigris.subversion.subclipse.ui.SVNUIPlugin.openError(org.eclipse.swt.widgets.Shell,String,String,Throwable,int)
SVNUIPlugin.java
org.tigris.subversion.subclipse.ui/src/org/tigris/subversion/subclipse/ui
line 284
OS:
org.tigris.subversion.subclipse.ui.wizards.generatediff.GenerateDiffFileOperation.run(org.eclipse.core.runtime.IProgressMonitor)
may fail to close stream GenerateDiffFileOperation.java
org.tigris.subversion.subclipse.ui/src/org/tigris/subversion/subclipse/ui/wizards/generatediff
line 80
OS:
org.tigris.subversion.svnclientadapter.javahl.AbstractJhlClientAdapter.propertySet(java.io.File,String,java.io.File,boolean)
may fail to close stream AbstractJhlClientAdapter.java
svnClientAdapter/src/main/org/tigris/subversion/svnclientadapter/javahl
line 1104
Others are almost as simple as quick-fix, so it would take longer to
make patches... and if you run FindBugs as an Eclipse plugin it will
give you these warnings right in the Problems view, so you are one click
away from the editor.
regards,
Eugene
Received on Fri Aug 26 13:22:22 2005