Drive by review ...
Is this the right thing to do? Doesn't SVN delete the actual folder/file?
Is this change only applying to some specific scenario?
On Mon, Aug 22, 2011 at 9:33 AM, <selsemore_at_tigris.org> wrote:
> Author: selsemore
> Date: 2011-08-22 06:33:24-0700
> New Revision: 5091
>
> Modified:
>
> trunk/subclipse/org.tigris.subversion.subclipse.core/src/org/tigris/subversion/subclipse/core/resources/SVNMoveDeleteHook.java
>
> Log:
> Move/delete hook should return false for deleteFile and deleteFolder
> methods
> (so that Eclipse will do its thing and do the actual delete after Subclipse
> is done).
>
> Modified:
> trunk/subclipse/org.tigris.subversion.subclipse.core/src/org/tigris/subversion/subclipse/core/resources/SVNMoveDeleteHook.java
> Url:
> http://subclipse.tigris.org/source/browse/subclipse/trunk/subclipse/org.tigris.subversion.subclipse.core/src/org/tigris/subversion/subclipse/core/resources/SVNMoveDeleteHook.java?view=diff&pathrev=5091&r1=5090&r2=5091
>
> ==============================================================================
> ---
> trunk/subclipse/org.tigris.subversion.subclipse.core/src/org/tigris/subversion/subclipse/core/resources/SVNMoveDeleteHook.java
> (original)
> +++
> trunk/subclipse/org.tigris.subversion.subclipse.core/src/org/tigris/subversion/subclipse/core/resources/SVNMoveDeleteHook.java
> 2011-08-22 06:33:24-0700
> @@ -74,15 +74,12 @@
> deletedFiles.add(file);
>
> deleteResource(resource);
> -
> - tree.deletedFile(file);
> -
> } catch (SVNException e) {
> tree.failed(e.getStatus());
> } finally {
> monitor.done();
> }
> - return true;
> + return false;
>
> }
>
> @@ -113,8 +110,7 @@
> } finally {
> monitor.done();
> }
> - return true;
> -
> + return false;
> }
>
> /*
>
> ------------------------------------------------------
>
> http://subclipse.tigris.org/ds/viewMessage.do?dsForumId=3541&dsMessageId=2827597
>
> To unsubscribe from this discussion, please e-mail [unsubscribeURL]
>
--
Thanks
Mark Phippard
http://markphip.blogspot.com/
------------------------------------------------------
http://subclipse.tigris.org/ds/viewMessage.do?dsForumId=1043&dsMessageId=2827599
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_subclipse.tigris.org].
Received on 2011-08-22 15:35:51 CEST