[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Subclipse-dev] Subclipse interaction with undo, from refactorings and otherwise

From: Scott Evans <gse_at_adobe.com>
Date: Thu, 10 Dec 2009 14:44:18 -0800

On 12/10/09 2:03 PM, "Mark Phippard" <markphip_at_gmail.com> wrote:

> On Thu, Dec 10, 2009 at 4:58 PM, Scott Evans <gse_at_adobe.com> wrote:
>> I work on the Adobe Flash Builder team. FB is based on Eclipse and we have
>> lots of Subclipse users.
>> In working on a refactoring feature, we¹ve noticed that after
>> programmatically deleting a directory in a Subclipse-controlled project, the
>> directory remains, with a .svn directory in it. This causes problems when
>> undoing the operation ‹ for instance, UndoDeleteResourceChange tries to
>> recreate the deleted directory and that blows up.
> svn delete of a folder will leave the folder in place until you
> commit. There is no way around that, except that in SVN 1.7 the
> working copy format is removing those .svn folders and so this issue
> will go away.

That's interesting; I didn't realize that. If .svn folders are going away
then it may not be worth worrying too much about.

>> In some testing, this problem appears to not be limited to Flash Builder or
>> to refactoring. In the JDT, if I simply delete a folder then try to undo the
>> delete, similar problems happen.
> I think there might be a general problem with undo that it does not
> trigger any SCM hooks or allow the SCM provider to be involved in the
> process as it is during the refactor. We technically need to be able
> to run svn revert here and there is no opportunity to do so.

Ugh, that's a drag.

And sure enough, it looks like P4WSAD doesn't do anything when you undo a
file delete either; the file remains marked for delete.

Thanks for the quick response and clarifications, Mark.



To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_subclipse.tigris.org].
Received on 2009-12-10 23:44:35 CET

This is an archived mail posted to the Subclipse Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.