[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Subclipse-dev] i created a eclipse bug report for something that with the current build doesnt work correctly any more with subclipse

From: jcompagner <jcompagner_at_gmail.com>
Date: Sat, 7 Feb 2009 23:05:29 +0100

ok the first one is for the left side of the compare window (local)
and the second one is from the right side of the compare window

So that seems to be just how it supposed to work but now back to the first
stack i send to this list
i guess that is the new stuff of eclipse compare window (a real compilation
unit so that you have all the java stuff (code completion) inside the
compare window)

DocumentAdapter.setContents(String) line: 495
CompilationUnitDocumentProvider.createFakeCompiltationUnit(IStorageEditorInput,
boolean) line: 1074
CompilationUnitDocumentProvider.createFakeCompiltationUnit(Object, boolean)
line: 1006
CompilationUnitDocumentProvider.connect(Object) line: 1203
JavaMergeViewer$CompilationUnitEditorAdapter(AbstractTextEditor).doSetInput(IEditorInput)
line: 4089

As far as i know should that be the left side of the compare window
But it gets the right sides editor input!
And that will generate a setContents with a string from the right sides
editor input that causes a dirty state of the left...

So something is screwed up here

johan

On Sat, Feb 7, 2009 at 21:33, Johan Compagner <jcompagner_at_gmail.com> wrote:

> Twice there is an editor input created and set:
>
> The first time it does create a a normal FileEditorInput:
>
> public IEditorInput getDocumentKey(Object element) {
> IFile file = getFile(element);
> if (file != null && file.exists()) {
> return new FileEditorInput(file);
> }
> return null;
> }
>
> Thread [main] (Suspended)
>
> EditableSharedDocumentAdapter(SharedDocumentAdapter).getDocumentKey(Object)
> line: 64
> TextMergeViewer$ContributorInfo.getDocumentKey() line: 923
> TextMergeViewer$ContributorInfo.connectToSharedDocument() line: 815
> TextMergeViewer$ContributorInfo.createDocument() line: 790
> TextMergeViewer$ContributorInfo.internalSetDocument(MergeSourceViewer)
> line: 670
> TextMergeViewer$ContributorInfo.setDocument(MergeSourceViewer, boolean)
> line: 634
> JavaMergeViewer(TextMergeViewer).updateContent(Object, Object, Object)
> line: 2811
> JavaMergeViewer(ContentMergeViewer).internalRefresh(Object) line:
> 737
> JavaMergeViewer(ContentMergeViewer).inputChanged(Object, Object) line:
> 637
> JavaMergeViewer(ContentViewer).setInput(Object) line: 274
> JavaMergeViewer.setInput(Object) line: 150
> CompareEditorInput$3(CompareViewerSwitchingPane).setInput(Object) line:
> 256
>
> SyncInfoCompareInput(CompareEditorInput).internalSetContentPaneInput(Object)
> line: 840
> CompareEditorInput.access$7(CompareEditorInput, Object) line: 838
> CompareEditorInput$13.run() line: 778
> BusyIndicator.showWhile(Display, Runnable) line: 70
> SyncInfoCompareInput(CompareEditorInput).feed1(ISelection) line: 772
>
> SyncInfoCompareInput(CompareEditorInput).feedInput() line: 750
> SyncInfoCompareInput(CompareEditorInput).createContents(Composite)
> line: 573
> CompareEditor.createCompareControl() line: 447
> CompareEditor.access$6(CompareEditor) line: 416
> CompareEditor$3.run() line: 372
> UILockListener.doPendingWork() line: 155
> UISynchronizer$3.run() line: 158
> RunnableLock.run() line: 35
> UISynchronizer(Synchronizer).runAsyncMessages(boolean) line: 133
> Display.runAsyncMessages(boolean) line: 3852
> Display.readAndDispatch() line: 3473
> Workbench.runEventLoop(Window$IExceptionHandler, Display) line: 2388
>
> Workbench.runUI() line: 2352
> Workbench.access$4(Workbench) line: 2204
> Workbench$5.run() line: 499
> Realm.runWithDefault(Realm, Runnable) line: 333
> Workbench.createAndRunWorkbench(Display, WorkbenchAdvisor) line: 492
>
> PlatformUI.createAndRunWorkbench(Display, WorkbenchAdvisor) line:
> 149
> IDEApplication.start(IApplicationContext) line: 113
> EclipseAppHandle.run(Object) line: 194
> EclipseAppLauncher.runApplication(Object) line: 110
> EclipseAppLauncher.start(Object) line: 79
> EclipseStarter.run(Object) line: 368
> EclipseStarter.run(String[], Runnable) line: 179
> NativeMethodAccessorImpl.invoke0(Method, Object, Object[]) line: not
> available [native method]
> NativeMethodAccessorImpl.invoke(Object, Object[]) line: not
> available
> DelegatingMethodAccessorImpl.invoke(Object, Object[]) line: not
> available
> Method.invoke(Object, Object...) line: not available
> Main.invokeFramework(String[], URL[]) line: 556
> Main.basicRun(String[]) line: 511
> Main.run(String[]) line: 1270
> Main.main(String[]) line: 1246
>
>
>
> The second time it creates:
>
> public IEditorInput getDocumentKey(Object element) {
> if (element == this && getBufferedStorage() != null) {
> return new FileRevisionEditorInput(new
> ResourceVariantFileRevision(remote), getBufferedStorage(),
> getLocalEncoding());
> }
> return null;
> }
>
> Thread [main] (Suspended)
> RemoteResourceTypedElement.getDocumentKey(Object) line: 71
> StorageTypedElement$1.getDocumentKey(Object) line: 120
> TextMergeViewer$ContributorInfo.getDocumentKey() line: 923
> TextMergeViewer$ContributorInfo.connectToSharedDocument() line: 815
> TextMergeViewer$ContributorInfo.createDocument() line: 790
> TextMergeViewer$ContributorInfo.internalSetDocument(MergeSourceViewer)
> line: 670
> TextMergeViewer$ContributorInfo.setDocument(MergeSourceViewer, boolean)
> line: 634
> JavaMergeViewer(TextMergeViewer).updateContent(Object, Object, Object)
> line: 2814
> JavaMergeViewer(ContentMergeViewer).internalRefresh(Object) line:
> 737
> JavaMergeViewer(ContentMergeViewer).inputChanged(Object, Object) line:
> 637
> JavaMergeViewer(ContentViewer).setInput(Object) line: 274
> JavaMergeViewer.setInput(Object) line: 150
> CompareEditorInput$3(CompareViewerSwitchingPane).setInput(Object) line:
> 256
>
> SyncInfoCompareInput(CompareEditorInput).internalSetContentPaneInput(Object)
> line: 840
> CompareEditorInput.access$7(CompareEditorInput, Object) line: 838
> CompareEditorInput$13.run() line: 778
> BusyIndicator.showWhile(Display, Runnable) line: 70
> SyncInfoCompareInput(CompareEditorInput).feed1(ISelection) line: 772
>
> SyncInfoCompareInput(CompareEditorInput).feedInput() line: 750
> SyncInfoCompareInput(CompareEditorInput).createContents(Composite)
> line: 573
> CompareEditor.createCompareControl() line: 447
> CompareEditor.access$6(CompareEditor) line: 416
> CompareEditor$3.run() line: 372
> UILockListener.doPendingWork() line: 155
> UISynchronizer$3.run() line: 158
> RunnableLock.run() line: 35
> UISynchronizer(Synchronizer).runAsyncMessages(boolean) line: 133
> Display.runAsyncMessages(boolean) line: 3852
> Display.readAndDispatch() line: 3473
> Workbench.runEventLoop(Window$IExceptionHandler, Display) line: 2388
>
> Workbench.runUI() line: 2352
> Workbench.access$4(Workbench) line: 2204
> Workbench$5.run() line: 499
> Realm.runWithDefault(Realm, Runnable) line: 333
> Workbench.createAndRunWorkbench(Display, WorkbenchAdvisor) line: 492
>
> PlatformUI.createAndRunWorkbench(Display, WorkbenchAdvisor) line:
> 149
> IDEApplication.start(IApplicationContext) line: 113
> EclipseAppHandle.run(Object) line: 194
> EclipseAppLauncher.runApplication(Object) line: 110
> EclipseAppLauncher.start(Object) line: 79
> EclipseStarter.run(Object) line: 368
> EclipseStarter.run(String[], Runnable) line: 179
> NativeMethodAccessorImpl.invoke0(Method, Object, Object[]) line: not
> available [native method]
> NativeMethodAccessorImpl.invoke(Object, Object[]) line: not
> available
> DelegatingMethodAccessorImpl.invoke(Object, Object[]) line: not
> available
> Method.invoke(Object, Object...) line: not available
> Main.invokeFramework(String[], URL[]) line: 556
> Main.basicRun(String[]) line: 511
> Main.run(String[]) line: 1270
> Main.main(String[]) line: 1246
>
>
> On Sat, Feb 7, 2009 at 16:57, Mark Phippard <markphip_at_gmail.com> wrote:
>
>> I looked at your bug report back when you posted it. Have you looked
>> at our code or CVS code since then to see if this is something we can
>> correct on our side?
>>
>> Some of that behavior you are seeing seems really weird. A couple
>> point releases ago someone added a patch to detect when things like
>> drag and drop happen and that does some stuff with revert etc. It is
>> based on resource listeners. I cannot think of why Compare would
>> trigger that code, but that is the only way I can think of that a
>> Revert could get triggered without taking an explicit option.
>>
>> My only other idea was if it is possible that something is seriously
>> broken in the linkage of the menu actions and when you take the
>> compare option additional actions are being triggered.
>>
>> Mark
>>
>>
>> On Sat, Feb 7, 2009 at 10:32 AM, jcompagner <jcompagner_at_gmail.com> wrote:
>> > in build I20090203-1200 they still didnt fix it.
>> > So as a warning to everyone that wants to use Eclipse 3.5M5, it is
>> really
>> > not workable with the subclipse plugin.
>> >
>> >
>> > On Fri, Jan 30, 2009 at 13:18, Johan Compagner <jcompagner_at_gmail.com>
>> wrote:
>> >>
>> >> see
>> >> https://bugs.eclipse.org/bugs/show_bug.cgi?id=263023
>> >>
>> >> dont know if subclipse maybe does something that is not really the way
>> it
>> >> supposed to be and now with the new compare window code it encounters
>> it
>> >> or if it is an eclipse bug (but cvs doesnt have that problem)
>> >>
>> >> johan
>> >>
>> >
>> >
>>
>>
>>
>> --
>> Thanks
>>
>> Mark Phippard
>> http://markphip.blogspot.com/
>>
>> ------------------------------------------------------
>>
>> http://subclipse.tigris.org/ds/viewMessage.do?dsForumId=1043&dsMessageId=1119811
>>
>> To unsubscribe from this discussion, e-mail: [
>> dev-unsubscribe_at_subclipse.tigris.org].
>>
>
>

------------------------------------------------------
http://subclipse.tigris.org/ds/viewMessage.do?dsForumId=1043&dsMessageId=1120837

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_subclipse.tigris.org].
Received on 2009-02-07 23:05:44 CET

This is an archived mail posted to the Subclipse Dev mailing list.