[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[Subclipse-dev] setIgnored() in org.tigris.subversion.subclipse.core.resources.LocalResource

From: <biczok_at_freemail.hu>
Date: Mon, 5 Jan 2009 08:43:45 -0800 (PST)

Hi,

Seems like when anyone calls setIgnored() in LocalResource.java it will end up throwing a NullPointerException.
The reason is that it calls the run() method of a newly created AddIgnoredPatternCommand with a null IProgressMonitor.

The actual code is this:

    public void setIgnored() throws SVNException {
        AddIgnoredPatternCommand command = new AddIgnoredPatternCommand(getParent(), resource.getName());
        command.run(null);
    }

Maybe nobody is calling this method currently, but shouldn't it do something like:

        command.run(new NullProgressMonitor());

to avoid future surprises?

Cheers,

Laca

------------------------------------------------------
http://subclipse.tigris.org/ds/viewMessage.do?dsForumId=1043&dsMessageId=1005723

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_subclipse.tigris.org].
Received on 2009-01-05 17:45:35 CET

This is an archived mail posted to the Subclipse Dev mailing list.