[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Subclipse-dev] SVN Ant patch: verbose attribute, cleanup and others

From: Joshua Frankamp <frankamp_at_gmail.com>
Date: Fri, 5 Dec 2008 10:35:44 -0800

> Verbose attribute to svn command (idea stolen
> from http://codefeed.com/blog/?p=82)

This seems heavy handed to me, to modify the log level of the current
logger... I looked at a couple other examples of a 'verbose' flag and
they weren't like that. Is there evidence anyone can provide that this
is a standard way of implementing increased verbosity?

> cleanup command

This was added in the recent 1.2.1 release. Thanks for the patch! I
modified the attribute path to be dir to match the rest of the tasks.

> Patch to add command that respect recurce parameter for svnFileSet

I tested this and it doesn't seem that recursion should be implemented
there. In my tests the fileset was already doing the directory walking
and I was able to add multiple levels at once. Do you have a test case
for this that shows that it doesn't work?

> Patch for svnConflicted selector (doesn't work with svnkit 1.2.0).

I have raised this as an issue in svnkit. As a rule, I'd rather not
kludge the code in svnant because it makes it difficult to debug
later. They have fixed it and added it to the trunk. It will be in
svnkit 1.2.2 and I will put it in the next version of svnant.



To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_subclipse.tigris.org].
Received on 2008-12-08 09:07:38 CET

This is an archived mail posted to the Subclipse Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.