[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Subclipse-dev] SVNActiveChangeSetCollector listens for changes in derived folders

From: Mark Phippard <markphip_at_gmail.com>
Date: Thu, 6 Nov 2008 09:01:18 -0500

Can you open an issue in our tracker and attach a patch that
implements your proposed solution?

On Thu, Nov 6, 2008 at 8:58 AM, Martin Ko <Martin.Koci_at_aura.cz> wrote:
> Hello,
>
> I've noticed that SVNActiveChangeSetCollector listens (=processes
> deltas) for all resources in derived folders.
>
> In my case it means processing of thousands .class files in
> target/classes or target/test-classes (it's standard maven layout). This
> takes amount of CPU time - for example, build of one of our project
> takes one minute without subclipse installed and 5 minutes with
> subclipse.
>
> The problem (or is it a feature? ) is not in subclipse itself, but in
> org.eclipse.team.internal.core.subscribers.SubscriberResourceCollector.class which comes from (internal?!) org.eclipse.team.
>
> That class - SubscriberResourceCollector - visits children of all
> derived folders. I think this feature is unintenional or can be
> optional.
>
> Please notice that there was a similar bug in Mylyn:
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=195229 ; I've fixed that
> with skipping all derived folders - see attached patch at that bug.
>
>
> And now what we (or at least me) can do with this problem. Unfortunately
> class hiearchy SubscriberChangeSetManager -> ActiveChangeSetManager does
> not allow any override of SubscriberResourceCollector - creation of that
> instance is completely private. It means either copy those two type in
> subclipse or open a bug et eclipse.org. But the second second solution
> can take years to solve.
>
>
> What do you think? Or am I completely wrong?
>
>
> Regards,
>
>
> Martin Ko
>
>
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe_at_subclipse.tigris.org
> For additional commands, e-mail: dev-help_at_subclipse.tigris.org
>
>

-- 
Thanks
Mark Phippard
http://markphip.blogspot.com/
Received on 2008-11-06 15:01:27 CET

This is an archived mail posted to the Subclipse Dev mailing list.