[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Subclipse-dev] Revision graph status and plan

From: Alberto Gimeno <gimenete_at_gmail.com>
Date: Mon, 22 Sep 2008 19:29:29 +0200

Is this the correct way to handle exceptions in the UI?

SVNUIPlugin.openError(getSite().getShell(), "Error", "Error while
showing the graph", exception);

On Wed, Sep 3, 2008 at 2:10 PM, Alberto Gimeno <gimenete_at_gmail.com> wrote:
> Yes, I haven't handled any exception. In Cache.java I just wrap any
> exception into a CacheException and all methods throw a
> CacheException. In the UI classes there are just try-catches with a
> "TODO" note and an e.printStackTrace(). I didn't know the way to
> prompt the user to tell about an exception has happened. I will take a
> look at those mechanisms for exception handling and I'll use them.
>
>
> On Thu, Aug 28, 2008 at 7:18 PM, Mark Phippard <markphip_at_gmail.com> wrote:
>> So yesterday I killed my Eclipse session because it was going to take
>> so long to build the cache of revision information. If I try it again
>> today, this error shows up:
>>
>> org.tigris.subversion.sublicpse.graph.cache.CacheException: Error
>> while reading log messages from file
>> at org.tigris.subversion.sublicpse.graph.cache.Cache.readNext(Cache.java:299)
>> at org.tigris.subversion.sublicpse.graph.cache.Cache.readNext(Cache.java:191)
>> at org.tigris.subversion.sublicpse.graph.cache.Cache.findRootNode(Cache.java:210)
>> at org.tigris.subversion.subclipse.graph.editors.GraphBackgroundTask.updateView(GraphBackgroundTask.java:114)
>> at org.tigris.subversion.subclipse.graph.editors.GraphBackgroundTask.execute(GraphBackgroundTask.java:85)
>> at org.tigris.subversion.subclipse.ui.operations.SVNOperation.run(SVNOperation.java:89)
>> at org.eclipse.team.internal.ui.actions.JobRunnableContext.run(JobRunnableContext.java:144)
>> at org.eclipse.team.internal.ui.actions.JobRunnableContext$ResourceJob.runInWorkspace(JobRunnableContext.java:72)
>> at org.eclipse.core.internal.resources.InternalWorkspaceJob.run(InternalWorkspaceJob.java:38)
>> at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)
>> Caused by: java.io.UTFDataFormatException: malformed input around byte 719
>> at java.io.DataInputStream.readUTF(DataInputStream.java:604)
>> at java.io.RandomAccessFile.readUTF(RandomAccessFile.java:875)
>> at org.tigris.subversion.sublicpse.graph.cache.Cache.readNext(Cache.java:263)
>> ... 9 more
>>
>>
>> The problem itself is not really unexpected given I killed Eclipse.
>> The problem is that the error is handled poorly. Nothing in the UI
>> let me know an error even happened. We have mechanisms you can use to
>> throw exceptions so that an error dialog comes up and it is recorded
>> in the Eclipse .log. We should be using those.
>>
>> --
>> Thanks
>>
>> Mark Phippard
>> http://markphip.blogspot.com/
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe_at_subclipse.tigris.org
>> For additional commands, e-mail: dev-help_at_subclipse.tigris.org
>>
>>
>
>
>
> --
> Alberto Gimeno Brieba
> Presidente y fundador de
> Ribe Software S.L.
> http://www.ribesoftware.com
> ribe_at_ribesoftware.com
>
> Contacto personal
> eMail: gimenete_at_gmail.com
> GTalk: gimenete_at_gmail.com
> msn: gimenete_at_hotmail.com
> página web: http://gimenete.net
> teléfono móvil: +34 625 24 64 81
>

-- 
Alberto Gimeno Brieba
Presidente y fundador de
Ribe Software S.L.
http://www.ribesoftware.com
ribe_at_ribesoftware.com
Contacto personal
eMail: gimenete_at_gmail.com
GTalk: gimenete_at_gmail.com
msn: gimenete_at_hotmail.com
página web: http://gimenete.net
web favorita: http://debugmodeon.com
teléfono móvil: +34 625 24 64 81
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subclipse.tigris.org
For additional commands, e-mail: dev-help_at_subclipse.tigris.org
Received on 2008-09-22 19:29:37 CEST

This is an archived mail posted to the Subclipse Dev mailing list.