[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Subclipse-dev] giving a shot at fixing deletions

From: Hugo Visser <hugo_at_botteaap.net>
Date: Sun, 13 Jul 2008 16:53:04 +0200

On Jul 13, 2008, at 4:32 PM, Mark Phippard wrote:
>
> It is cool you are trying to solve it this way. Here are a couple of
> quick comments on this patch. Testing on Eclipse 3.2 in Windows:
>
> 1) It does not seem to work on what I think is the primary use case --
> Drag and Drop or Copy/Paste over an existing resource. The revert is
> never happening. If I delete the file first. Then Drag and Drop or
> Copy/Paste it does work. So the events must come through a bit
> differently when the file exists.

I've focussed testing on deleting stuff and then copying or recreating
files again. I've not tested the copy/paste on 3.2 that well so I'll
look into that now. The thing is that the copy/paste problem is a
strange one, I can't seem to reproduce it every time so I'll have to
dig a littebit deeper on that one or check previous subclipse releases
to see if something was changed in that area.

> 2) When the code does work, your .svntmp file is showing up in the
> Eclipse view. Refresh gets rid of it.
>
> I have not tried a folder yet, but I am curious what to expect. It
> sounds like if I delete a folder, and then add a file to it, what I
> should expect is the folder itself and the file I add should be
> expected to remain. But anything else that was still in the folder
> should be a delete still?

Yes, that's correct. It should only revert the directory, but not the
contents of the directory. I previously saw the refresh issue too so I
moved the resource.touch() after updating the statuscache. I think the
whole operation should run in a more atomic fashion (maybe in a
WorkspaceJob?) so that Eclipse is not refreshing anything before the
operation is finished. One other thing you see is that the files are
still marked deleted for a moment until the view gets refreshed. So
there's an extra refresh happening somewhere.

So I'll focus some more on Windows and Eclipse 3.2 and try to get
those bugs out.

Thanks for looking at the patch and your comments on it.

Hugo

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subclipse.tigris.org
For additional commands, e-mail: dev-help_at_subclipse.tigris.org
Received on 2008-07-13 16:53:17 CEST

This is an archived mail posted to the Subclipse Dev mailing list.