[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Subclipse-dev] History as revision graph

From: Steve Elsemore <selsemore_at_collab.net>
Date: Wed, 02 Jul 2008 08:11:00 -0700

Alberto,

I don't think the view should listen for selections and refresh
automatically. Even as a background task I think this would be too
intrusive. In my opinion, it should be more like the History View (Team ->
Show History) which requires explicit selection of the context menu option.

To enable the menu option for all resources (files and folders), you need to
change you popupMenus objectContribution (plugin.xml).

Change: objectClass="org.eclipse.core.resources.IFile"
To: objectClass="org.eclipse.core.resources.IResource"

After that line, add: adaptable="true"

There is currently a runtime error in ViewGraphAction. If you look in your
error log you will see an "Unhandled event loop exception" (due to an array
index error) whenever you run the action (the view has already been opened
at this point). This is happening at line 27:

view.showGraphFor(resources[0].getResource());

The problem is that resources is an empty array. This is because you are
initializing it using getSelectedRemoteResources() or
getSelectedRemoteFolders(), but the selection does not contain remote
resources (it contains IResource's).

Eventually we will want the option to also be available for remote resources
(SVN Repositories View selections).

Finally, I'm not sure if we discussed View vs. Editor for our
implementation? The view is nice, but there might be some advantages to an
editor such as being able to easily open several graphs at once, and
possibly utilizing more GEF features. Just a thought.

Thanks,
Steve

On 7/2/08 7:11 AM, "Alberto Gimeno" <gimenete_at_gmail.com> wrote:

> Thanks to all.
>
> I have commited the latest version of my code. And I have posted a
> screenshot in my blog:
> http://gimenetegsoc.wordpress.com/2008/07/02/integrating-the-graph-into-eclips
> e/
>
> The code compiles with the latest subclipse code (the
> createSVNClient() problem). And it runs as a background task (thanks
> Steve).
>
> Now the main code is in the View, not in the popup Action. Well,
> actually the main code is in the background task that is launched from
> the View. The popup Action just opens the view. That code is based on
> the ShowHistoryAction.
>
> Now the plugin depends on Eclipse GEF. I use the minimial things from
> GEF. Just to put the graph into an Eclipse View and make it scalable
> and scrollable.
>
> I have some issues to resolve.
> * The SelectionListener appears to not work as I supposed. Sometimes
> you change the selection in the package explorer and the view doesn't
> refresh. However if you change to other window in your SO, and then
> you come back to eclipse it works.
> * I'm not sure how to do that the popup was enabled to any selection
> (IFile, IResource,...). If I select a .java file I get a
> CompilationUnit objet that is not a subclass of IResource. The same
> with the SelectionListener.
>
>
>
> On Wed, Jul 2, 2008 at 3:12 AM, Eugene Kuleshov <eu_at_md.pp.ru> wrote:
>> Alberto,
>>
>> There is an excellent article on background processing and progress
>> indication in Eclipse at
>> http://www.eclipse.org/articles/Article-Concurrency/jobs-api.html
>>
>> regards,
>> Eugene
>>
>>
>> Alberto Gimeno wrote:
>>>
>>> Hi
>>>
>>> Sorry, I've been a little busy these days. I will fix this issues as
>>> soon as possible. Now I'm working on providing a deeper integration
>>> into eclipse. I'm learning the eclipse APIs. I want to provide a
>>> progress bar and also I'm learning how to show the graph into an
>>> eclipse view / editor.
>>>
>>> I have published a new post in my blog:
>>> http://gimenetegsoc.wordpress.com/ talking a little about the cache
>>> design.
>>>
>>>
>>> On Mon, Jun 30, 2008 at 9:10 PM, Mark Phippard <markphip_at_gmail.com> wrote:
>>>
>>>>
>>>> On Mon, Jun 30, 2008 at 1:04 PM, Alberto Gimeno <gimenete_at_gmail.com>
>>>> wrote:
>>>>
>>>>>
>>>>> I'll fix those errors in the next commit.
>>>>>
>>>>> Thank you very much for your comments.
>>>>>
>>>>
>>>> I hacked in a fix to insert a "" in place of null and that got me
>>>> further. I did see this exception which seemed less fatal than the
>>>> previous:
>>>>
>>>> /branches/ebcdic/trunk/subversion/bindings/swig/proxy/apr_h.swg at
>>>> 17006 already exists
>>>> when calculating branches for copy of
>>>> /branches/ebcdic/trunk/subversion/bindings/swig/proxy from
>>>> /trunk/subversion/bindings/swig/proxy/apr_h.swg
>>>> /branches/ebcdic/trunk/subversion/bindings/swig/proxy/proxy_apr.swg at
>>>> 17006 already exists
>>>> when calculating branches for copy of
>>>> /branches/ebcdic/trunk/subversion/bindings/swig/proxy from
>>>> /trunk/subversion/bindings/swig/proxy/proxy_apr.swg
>>>> /tags/ebcdic/1.3.2/tools/server-side/svnauthz-validate.c at 19943 already
>>>> exists
>>>> when calculating branches for copy of
>>>> /tags/ebcdic/1.3.2/tools/server-side from
>>>> /branches/ebcdic/1.3.x/tools/server-side/svnauthz-validate.c
>>>> / not in revision 26429
>>>> java.lang.NullPointerException
>>>> at
>>>> org.tigris.subversion.sublicpse.graph.cache.Cache.getFileId(Cache.java:516)
>>>> at
>>>> org.tigris.subversion.sublicpse.graph.cache.Cache.modifiedAction(Cache.java
>>>> :470)
>>>> at
>>>> org.tigris.subversion.sublicpse.graph.cache.Cache.update(Cache.java:405)
>>>> at
>>>> org.tigris.subversion.subclipse.graph.popup.actions.ViewGraphAction$1.run(V
>>>> iewGraphAction.java:90)
>>>> at
>>>> org.tigris.subversion.subclipse.ui.repository.RepositoryManager.run(Reposit
>>>> oryManager.java:375)
>>>> at
>>>> org.tigris.subversion.subclipse.ui.actions.SVNAction$1.run(SVNAction.java:2
>>>> 26)
>>>> at
>>>> org.tigris.subversion.subclipse.ui.actions.SVNAction$2.run(SVNAction.java:2
>>>> 35)
>>>> at
>>>> org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:67)
>>>>
>>>>
>>>> --
>>>> Thanks
>>>>
>>>> Mark Phippard
>>>> http://markphip.blogspot.com/
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe_at_subclipse.tigris.org
>>>> For additional commands, e-mail: dev-help_at_subclipse.tigris.org
>>>>
>>>>
>>>>
>>>
>>>
>>>
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe_at_subclipse.tigris.org
>> For additional commands, e-mail: dev-help_at_subclipse.tigris.org
>>
>>
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subclipse.tigris.org
For additional commands, e-mail: dev-help_at_subclipse.tigris.org
Received on 2008-07-02 17:11:12 CEST

This is an archived mail posted to the Subclipse Dev mailing list.