Re: [Subclipse-dev] History as revision graph

On Mon, Jun 30, 2008 at 1:04 PM, Alberto Gimeno <gimenete_at_gmail.com> wrote:
> I'll fix those errors in the next commit.
>
> Thank you very much for your comments.

It does look good. A couple more suggestions:

1) I'd suggest moving the Revision Graph option to the Team menu.

2) Given how long it takes to build the cache, the whole thing should
be runnable as a background operation. Steve Elsemore should be able
to help you with that.

3) Finally, I was testing with a file from the SVN repository and got
this error:

getCache(): 1927
getLogMessages(): 332754 31911 messages
org.tigris.subversion.sublicpse.graph.cache.CacheException: Error
inserting revision
        at org.tigris.subversion.sublicpse.graph.cache.Cache.insertRevision(Cache.java:162)
        at org.tigris.subversion.sublicpse.graph.cache.Cache.update(Cache.java:381)
        at org.tigris.subversion.subclipse.graph.popup.actions.ViewGraphAction$1.run(ViewGraphAction.java:90)
        at org.tigris.subversion.subclipse.ui.repository.RepositoryManager.run(RepositoryManager.java:375)
        at org.tigris.subversion.subclipse.ui.actions.SVNAction$1.run(SVNAction.java:226)
        at org.tigris.subversion.subclipse.ui.actions.SVNAction$2.run(SVNAction.java:235)
        at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:67)
        at org.tigris.subversion.subclipse.ui.actions.SVNAction.run(SVNAction.java:232)
        at org.tigris.subversion.subclipse.graph.popup.actions.ViewGraphAction.execute(ViewGraphAction.java:56)
        at org.tigris.subversion.subclipse.ui.actions.SVNAction.run(SVNAction.java:56)
        at org.eclipse.ui.actions.ActionDelegate.runWithEvent(ActionDelegate.java:70)
        at org.eclipse.ui.internal.PluginAction.runWithEvent(PluginAction.java:246)
        at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:546)
        at org.eclipse.jface.action.ActionContributionItem.access$2(ActionContributionItem.java:490)
        at org.eclipse.jface.action.ActionContributionItem$5.handleEvent(ActionContributionItem.java:402)
        at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:66)
        at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1495)
        at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1519)
        at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1504)
        at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:1295)
        at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3350)
        at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:2950)
        at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2389)
        at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2353)
        at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2219)
        at org.eclipse.ui.internal.Workbench$4.run(Workbench.java:466)
        at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:289)
        at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:461)
        at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
        at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:106)
        at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:169)
        at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:106)
        at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:76)
        at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:363)
        at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:176)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
        at java.lang.reflect.Method.invoke(Method.java:585)
        at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:508)
        at org.eclipse.equinox.launcher.Main.basicRun(Main.java:447)
        at org.eclipse.equinox.launcher.Main.run(Main.java:1173)
        at org.eclipse.equinox.launcher.Main.main(Main.java:1148)
Caused by: java.sql.SQLException: Column 'AUTHOR' cannot accept a NULL value.
        at org.apache.derby.impl.jdbc.SQLExceptionFactory.getSQLException(Unknown
Source)
        at org.apache.derby.impl.jdbc.Util.generateCsSQLException(Unknown Source)
        at org.apache.derby.impl.jdbc.TransactionResourceImpl.wrapInSQLException(Unknown
Source)
        at org.apache.derby.impl.jdbc.TransactionResourceImpl.handleException(Unknown
Source)
        at org.apache.derby.impl.jdbc.EmbedConnection.handleException(Unknown Source)
        at org.apache.derby.impl.jdbc.ConnectionChild.handleException(Unknown Source)
        at org.apache.derby.impl.jdbc.EmbedStatement.executeStatement(Unknown Source)
        at org.apache.derby.impl.jdbc.EmbedPreparedStatement.executeStatement(Unknown
Source)
        at org.apache.derby.impl.jdbc.EmbedPreparedStatement.executeUpdate(Unknown
Source)
        at org.tigris.subversion.sublicpse.graph.cache.Cache.insertRevision(Cache.java:160)
        ... 42 more
Caused by: ERROR 23502: Column 'AUTHOR' cannot accept a NULL value.
        at org.apache.derby.iapi.error.StandardException.newException(Unknown Source)
        at org.apache.derby.impl.sql.execute.NormalizeResultSet.normalizeRow(Unknown
Source)
        at org.apache.derby.impl.sql.execute.NormalizeResultSet.getNextRowCore(Unknown
Source)
        at org.apache.derby.impl.sql.execute.DMLWriteResultSet.getNextRowCore(Unknown
Source)
        at org.apache.derby.impl.sql.execute.InsertResultSet.open(Unknown Source)
        at org.apache.derby.impl.sql.GenericPreparedStatement.execute(Unknown Source)
        ... 46 more
java.lang.NullPointerException
        at org.tigris.subversion.subclipse.graph.popup.actions.ViewGraphAction$1.run(ViewGraphAction.java:102)
        at org.tigris.subversion.subclipse.ui.repository.RepositoryManager.run(RepositoryManager.java:375)
        at org.tigris.subversion.subclipse.ui.actions.SVNAction$1.run(SVNAction.java:226)
        at org.tigris.subversion.subclipse.ui.actions.SVNAction$2.run(SVNAction.java:235)
        at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:67)
        at org.tigris.subversion.subclipse.ui.actions.SVNAction.run(SVNAction.java:232)
        at org.tigris.subversion.subclipse.graph.popup.actions.ViewGraphAction.execute(ViewGraphAction.java:56)
        at org.tigris.subversion.subclipse.ui.actions.SVNAction.run(SVNAction.java:56)
        at org.eclipse.ui.actions.ActionDelegate.runWithEvent(ActionDelegate.java:70)
        at org.eclipse.ui.internal.PluginAction.runWithEvent(PluginAction.java:246)
        at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:546)
        at org.eclipse.jface.action.ActionContributionItem.access$2(ActionContributionItem.java:490)
        at org.eclipse.jface.action.ActionContributionItem$5.handleEvent(ActionContributionItem.java:402)
        at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:66)
        at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1495)
        at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1519)
        at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1504)
        at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:1295)
        at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3350)
        at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:2950)
        at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2389)
        at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2353)
        at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2219)
        at org.eclipse.ui.internal.Workbench$4.run(Workbench.java:466)
        at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:289)
        at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:461)
        at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
        at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:106)
        at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:169)
        at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:106)
        at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:76)
        at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:363)
        at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:176)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
        at java.lang.reflect.Method.invoke(Method.java:585)
        at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:508)
        at org.eclipse.equinox.launcher.Main.basicRun(Main.java:447)
        at org.eclipse.equinox.launcher.Main.run(Main.java:1173)
        at org.eclipse.equinox.launcher.Main.main(Main.java:1148)

-- 
Thanks
Mark Phippard
http://markphip.blogspot.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subclipse.tigris.org
For additional commands, e-mail: dev-help_at_subclipse.tigris.org