Mark Phippard wrote:
>> Yes I saw your changes, but haven't looked closely. Stuff seem to
>> compile ok. We need to manually test changeset support and project
>> linking based on svn properties, but I am not sure I'll have much time
>> for this before Sunday.
> My main concern was whether the dependencies are all still correct. I
> mostly Eclipse do all the work.
I committed small fixes for wrong class names and feature description.
Still haven't done any real testing.
>> One thing I'd like to suggest is to align Subclipse project names and
>> their folders in svn. Right now some of them are using long names and
>> some - short ones (like "subclipse_mylyn_feature", or "feature"). And we
>> may need to update feature description for mylar stuff (i.e. say that it
>> is optional and verify all descriptions).
> I have done that in trunk for all the projects that still matter. The
> only exception is the feature project and that is because it should be
> the same name as the plugin project.
Feature project name is "feature" and doc plugin is called
"subclipse-doc" (one would expect it to be something like
"org.tigris.subversion.subclipse.doc"). Sorting in package explorer is
kinda odd when those projects aren't using common prefix.
Also project folders in svn named inconsistently, i.e. /doc and /core,
vs. /org.tigris.subversion.clientadapter
>> Also, are you planning to do this "compatibility" trick? I don't think
>> it is really necessary.
> I probably will. My main concern if I do not is that the dependency
> of the old project on Mylar might prevent someone from cleaning up
> Mylar or something like that.
Thing is that if user already updated to new Mylar stuff, extension
points in old Subclipse plugin for Mylar won't be loaded, so we should
be fine without those tricks. Though it may worth to try that.
regards,
Eugene
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subclipse.tigris.org
For additional commands, e-mail: dev-help@subclipse.tigris.org
Received on Fri Jun 22 18:24:40 2007